[csharp-netcore] Propagate raw content to the ApiException error content. #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimschubert
reviewed
Nov 6, 2019
modules/openapi-generator/src/main/resources/csharp-netcore/ApiResponse.mustache
Show resolved
Hide resolved
|
@jimschubert it looks like |
jimschubert
approved these changes
Nov 11, 2019
|
Hi all, thanks for fixing up this issue, do you know when it might get merged and released? |
jimschubert
added a commit
that referenced
this pull request
Nov 13, 2019
* master: [csharp-netcore] Propagate raw content to the ApiException error content. (#4381) Remove path relative to my home dir. (#4470) Avoid generating uncompilable response body in Spring's API template (#2903) cpp-qt5-client: remove host since it is not well handled (#4429) [Java] Refactor webClient generator to use URI templates to capture correct metrics (#4314) [Java]: Client resttemplate and webclient: array parameters of type integer in path badly generated (#4379) Dart generate keywords (#4449) [core] Fix system properties being immutable (#4447) [Kotlin][Client] minor improvements (#4419) [typescript-rxjs]: Add support for nullable (#4438) [asciidoc] fix names of parameters (#4440)
|
@yzhoholiev thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue with the ApiException error content described in #3473 .
The issue is linked to migration to the generic
IRestResponse<T>. The deserialization happens before the exception is actually checked byExceptionFactory.Possible fix is to propagate both raw response content from
IRestResponse.Contentas well asIRestResponse<T>.Datato theApiResponse.But I think it makes sense to roll back to the older implementation, where deserialization happed if an exception hadn't been constructed.
Technical committee: @mandrean (2017/08), @jimschubert (2017/09) ❤️ @frankyjuang (2019/09)