Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Client resttemplate and webclient: array parameters of type integer in path badly generated #4379

Merged
merged 7 commits into from
Nov 12, 2019

Conversation

jorgerod
Copy link
Contributor

@jorgerod jorgerod commented Nov 5, 2019

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

Description of the PR

Addresses issue #4375 for java resttemplate and java webclient

@wing328
Copy link
Member

wing328 commented Nov 7, 2019

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@jorgerod
Copy link
Contributor Author

jorgerod commented Nov 7, 2019

@wing328 I think I have already solved it. It's OK now?

Thank you

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 94b5863 into OpenAPITools:master Nov 12, 2019
@wing328 wing328 added this to the 4.2.1 milestone Nov 12, 2019
@wing328 wing328 changed the title [Java]: Client resttemplate and webclient: array parameters of type integer in path badly generated [Java] Client resttemplate and webclient: array parameters of type integer in path badly generated Nov 12, 2019
jimschubert added a commit that referenced this pull request Nov 13, 2019
* master:
  [csharp-netcore] Propagate raw content to the ApiException error content. (#4381)
  Remove path relative to my home dir. (#4470)
  Avoid generating uncompilable response body in Spring's API template (#2903)
  cpp-qt5-client: remove host since it is not well handled (#4429)
  [Java] Refactor webClient generator to use URI templates to capture correct metrics (#4314)
  [Java]: Client resttemplate and webclient: array parameters of type integer in path badly generated (#4379)
  Dart generate keywords (#4449)
  [core] Fix system properties being immutable (#4447)
  [Kotlin][Client] minor improvements (#4419)
  [typescript-rxjs]: Add support for nullable (#4438)
  [asciidoc] fix names of parameters (#4440)
@wing328
Copy link
Member

wing328 commented Nov 15, 2019

@jorgerod thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants