Refactor date and duration components to work in jinja2 environments #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ital/design-system into fix-date-duration-inputs-in-jinja
precious-onyenaucheya-ons
approved these changes
Mar 12, 2024
…ital/design-system into fix-date-duration-inputs-in-jinja
SriHV
approved these changes
Mar 12, 2024
…ital/design-system into fix-date-duration-inputs-in-jinja
2d178a8 to
650d2bc
Compare
alessioventuriniAND
approved these changes
Mar 13, 2024
…ital/design-system into fix-date-duration-inputs-in-jinja
rmccar
added a commit
that referenced
this pull request
Mar 25, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3081
Recently the duration and date components were refactored to move any duplication of logic into a single shared macro. This was done using the
.pushmethod which is used in nunjucks to push the fields used in the macros into an array which was then used in the shared macro. The.pushmethod is not compatible with jinja2 and is causing errors when using the components. This has needed another refactor to make sure it is working in jinja2 environments. So I have moved the use of the input component back into the individual date and duration marcos themselves to remove the need to use.push.As part of this I have also standardised the params and tests that are used across the two components.
How to review this PR
Test components still work as expected after the refactor and the changes make sense.
Checklist
This needs to be completed by the person raising the PR.