Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor share-page macro to suit Jinja2 templates #3170

Closed
SriHV opened this issue May 1, 2024 · 0 comments · Fixed by #3177
Closed

Refactor share-page macro to suit Jinja2 templates #3170

SriHV opened this issue May 1, 2024 · 0 comments · Fixed by #3177
Assignees
Labels
Bug Something isn't working High priority

Comments

@SriHV
Copy link
Contributor

SriHV commented May 1, 2024

While testing nunjucks files in Jinja Environment(as part of the #3086), few examples showed ‘internal server error’. The main cause of this issue is the differences between Nunjucks (a templating language in JS environments and DS) and Jinja2 (a templating language used by flask in python). Macros need refactoring so it can suit Jinja2 template. This was addressed previously in #3080.

The errors are split up to simplify while refactoring.

components/share-page/example-share-page.njk threw error jinja2.exceptions.UndefinedError: 'list object' has no attribute 'push' : This is due to push, as a function, not identified by the lists in python. share-page needs refactoring

@SriHV SriHV added Enhancement Change of existing feature High priority labels May 1, 2024
@SriHV SriHV self-assigned this May 1, 2024
@SriHV SriHV added Bug Something isn't working and removed Enhancement Change of existing feature labels May 2, 2024
@SriHV SriHV linked a pull request May 7, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant