Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor document-list macros to suit Jinja2 templates #3163

Closed
SriHV opened this issue Apr 26, 2024 · 0 comments · Fixed by #3179
Closed

Refactor document-list macros to suit Jinja2 templates #3163

SriHV opened this issue Apr 26, 2024 · 0 comments · Fixed by #3179
Assignees
Labels
Bug Something isn't working High priority

Comments

@SriHV
Copy link
Contributor

SriHV commented Apr 26, 2024

While testing nunjucks files in Jinja Environment(as part of the #3086), few examples showed ‘internal server error’. The main cause of this issue is the differences between Nunjucks (a templating language in JS environments and DS) and Jinja2 (a templating language used by flask in python). Macros need refactoring so it can suit Jinja2 template. This was addressed previously in #3080.

The errors are split up to simplify while refactoring.

components/document-list/example-document-list-downloads.njk threw error jinja2.exceptions.UndefinedError: 'list object' has no attribute 'push' : This is due to push, as a function, not identified by the lists in python. Document-list needs refactoring

@SriHV SriHV added High priority Enhancement Change of existing feature labels Apr 26, 2024
@SriHV SriHV changed the title Refactor macros to suit Jinja2 templates Refactor document-list macros to suit Jinja2 templates May 1, 2024
@rmccar rmccar added the Bug Something isn't working label May 2, 2024
@SriHV SriHV removed the Enhancement Change of existing feature label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants