Refactor document-list macro for compatibility Jinja2 templates #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alessioventuriniAND
approved these changes
May 8, 2024
SriHV
approved these changes
May 8, 2024
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
adi-unni
approved these changes
May 10, 2024
rmccar
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes #3163
Removed .push method which was used for adding file metadata information to a list. This is done to make document list component work with Jinja templates.
How to review this PR
Test the changes in Design system
Pull the latest PR (https://github.com/ONSdigital/design-system-python-flask-demo/pull/3) which is in review. Follow the updated readme.
Update the macro and test it in Flask.
Checklist
This needs to be completed by the person raising the PR.