electron*: mark older versions as EOL

[alyssais]

Description of changes

https://www.electronjs.org/docs/latest/tutorial/electron-timelines#timeline

Some discussion in #318857 (comment).

Heads up to maintainers of applications that should be updated to avoid using these versions:

• feishin @onny @jlbribeiro
• logseq (unmaintained)
• ride @TomaSajt @markus1189
• micropad @rhysmdnz
• pocket-casts @WolfangAukang
• webtorrent_desktop @bendlas
• whalebird @WolfangAukang @uninsane @Weathercold
• deltachat-desktop @dotlambda
• mattermost-desktop @jokogr
• bitwarden-desktop @amarshall @Kiwi
• blockbench @ckiee @TomaSajt
• lx-music-desktop @oo-infty
• morgen @justanotherariel @WolfangAukang
• obsidian @AtilaSaraiva @ConradMearns @zaninime @qbit @kashw2 @w-lfchen

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[vcunat]

Looks OK to me, though I don't really know electron stuff in particular.

[SuperSandro2000]

We need to wait for the next bitwarden-desktop release to contain bitwarden/clients@a4dd1f4 or just bump to electron 28.

[vcunat]

28 is also EOL now. EDIT: and more urgently, it's about to get broken: https://hydra.nixos.org/build/262684505

[yayayayaka]

Thanks!

[onny]

Added a upstream bug report for Feishin about updating Electron version jeffvli/feishin#643

[SuperSandro2000]

28 is also EOL now

That's an arbitrary decision we can also delay by a week or two with no hard drawbacks. It only becomes a problem if we delay it for a long time.

Having to compile electron is a hard drawback and most people cannot even do that or it becomes an unreasonable hard and unjustifiable burden just to have that EOL version up to date.

Also that build failure seems to be just a gcc warning being treated as error. We can ignore that.

[SuperSandro2000]

Noise, they literally tagged a release 30 minutes ago https://github.com/bitwarden/clients/releases/tag/desktop-v2024.6.0

[emilylange]

Don't we usually remove the EOL electron-source versions and mark the binary electron_*-bin version EOL?
Not both?

See #295672 (c45702d and 1f9c426).

[vcunat]

@SuperSandro2000 as I mentioned above, electron 27 and 28 also won't build now anymore (due to LLVM incompatibilities).

[vcunat]

They now fail to build on nixpkgs master, so I merged already to avoid Hydra expending lots of resources on futile builds.

[emilylange]

Don't we usually remove the EOL electron-source versions and mark the binary electron_*-bin version EOL? Not both?

See #295672 (c45702d and 1f9c426).

I opened #319415 for what I meant, including version conditional cleanups in both the underlying chromium derivation and electron-source.

[yu-re-ka]

For reference, the intention when adding source-built electron was to keep around only non-EOL versions as source-built, so once they go EOL, it should be switched over to the binary version (which should also be marked as EOL) as done in #319415