Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron updates #295672

Merged
merged 7 commits into from
Mar 14, 2024
Merged

Electron updates #295672

merged 7 commits into from
Mar 14, 2024

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Mar 13, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yu-re-ka
Copy link
Contributor Author

Built electron_27, electron_28 on x86_64-linux
Built electron_29 on aarch64-linux and performed manual tests with element-desktop

- provide passthru.fetchedDeps for debugging
- adapt gn args for latest electron versions
- fix mechanism for applying patches for latest electron versions
@yu-re-ka yu-re-ka merged commit 9f26152 into NixOS:master Mar 14, 2024
21 of 23 checks passed
@yu-re-ka yu-re-ka deleted the electron-29 branch March 14, 2024 11:29
@emilylange
Copy link
Member

Result of nixpkgs-review pr 295672 run on x86_64-linux 1

1 package failed to build:
  • redisinsight
57 packages built:
  • authy
  • bilibili
  • bitwarden-desktop
  • bitwarden-directory-connector
  • bruno
  • camunda-modeler
  • deltachat-desktop
  • drawio
  • drawio-headless
  • electron
  • electron_27
  • electron_28
  • element-desktop
  • element-desktop-wayland
  • freetube
  • geogebra6
  • headset
  • heroic
  • heroic-unwrapped
  • itch
  • jitsi-meet-electron
  • logseq
  • mattermost-desktop
  • micropad
  • morgen
  • nix-tour
  • obsidian
  • open-stage-control
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • pocket-casts
  • podman-desktop
  • pritunl-client
  • python311Packages.mkdocs-drawio-exporter
  • python311Packages.mkdocs-drawio-exporter.dist
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • revolt-desktop
  • sharedown
  • standardnotes
  • stretchly
  • super-productivity
  • teams-for-linux
  • terra-station
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • webcord
  • webcord-vencord
  • webtorrent_desktop
  • youtube-music
  • ytdownloader

@teutat3s
Copy link
Member

teutat3s commented Apr 2, 2024

@yu-re-ka Do you have time to backport electron 29?

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-295672-to-release-23.11 origin/release-23.11
cd .worktree/backport-295672-to-release-23.11
git switch --create backport-295672-to-release-23.11
git cherry-pick -x 06227618a1381eab4a2f10ec11dc9e5c0e7feeb6 f3fb7b5980cdc8e93d9a0ee0e9a4e58c451a9ff8 806db42d25e1a95234dd6d87c0eb71e9001913ea f5dc5df8d46a5681a84684a6512851b2264a1d76 c45702dfc951818ae096aafc34b0eea990bc9a36 1f9c426744ca908110a8ab392352c843ca07a7c3 ea0df4c23b0c18cee92c2497ef04892e7d0febad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants