Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webtorrent_desktop: update and use latest electron #320293

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Jun 16, 2024

Description of changes

After #319252, we need to use a more recent electron
After webtorrent/webtorrent-desktop#2388, we can drop the patch for electron >=27

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bendlas bendlas force-pushed the webtorrent-desktop-update-electron branch from b7b91f7 to 531caf7 Compare June 24, 2024 08:45
@bendlas bendlas marked this pull request as ready for review June 24, 2024 08:46
@bendlas bendlas merged commit 62db0a5 into NixOS:master Jun 24, 2024
12 of 13 checks passed
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-320293-to-release-24.05 origin/release-24.05
cd .worktree/backport-320293-to-release-24.05
git switch --create backport-320293-to-release-24.05
git cherry-pick -x 62db0a59de47a0d343bb7bedd4e65ebad135d66d

@emilazy emilazy mentioned this pull request Aug 27, 2024
13 tasks
emilazy pushed a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants