Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a condition to turn off samfdeepcnv when MYNN shallow convection active #714

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

XiaqiongZhou-NOAA
Copy link
Contributor

Description

Add a switch to turn off samfdeepcnv when MYNN shallow convection active.
The answer will be changed if both SaSAS deep convection and MYNN schemes are used.

Testing

Tested on WCOSS2 and hera intel

Dependencies

ufs-community/ccpp-physics#121

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA changed the title Add a switch to turn off samfdeepcnv when MYNN shallow convection active Add a condition to turn off samfdeepcnv when MYNN shallow convection active Oct 20, 2023
@XiaqiongZhou-NOAA XiaqiongZhou-NOAA marked this pull request as ready for review October 20, 2023 17:01
@grantfirl
Copy link
Collaborator

@XiaqiongZhou-NOAA ufs-community/ccpp-physics#121 was merged. Please revert the changes to .gitmodules and point to the latest commit of the ufs/dev branch of ccpp/physics: ufs-community/ccpp-physics@c2ec9e5

@zach1221
Copy link
Collaborator

zach1221 commented Nov 9, 2023

@jkbk2004 we have approvals here. Feel free to merge.

@jkbk2004 jkbk2004 merged commit 36500b6 into NOAA-EMC:develop Nov 9, 2023
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/fv3atm that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants