Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a condition to turn off samfdeepcnv when MYNN shallow convection active #1953

Merged
merged 15 commits into from
Nov 9, 2023

Conversation

XiaqiongZhou-NOAA
Copy link
Contributor

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA commented Oct 20, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.

  • I am confirming reviews are completed in ALL sub-component PR's.

  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:

  • I have added the list of all failed regression tests to "Anticipated changes" section.

  • I have filled out all sections of the template.

Description

To add a condition to turn off samfdeepcnv when the MYNN shallow convection is active.

Linked Issues and Pull Requests

Subcomponent Pull Requests

ufs-community/ccpp-physics#121
NOAA-EMC/fv3atm#714

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
    control_p8_mynn_intel

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA marked this pull request as ready for review October 20, 2023 17:01
@zach1221
Copy link
Collaborator

zach1221 commented Nov 8, 2023

Hi, @XiaqiongZhou-NOAA . I think we're ready to begin testing against your PR. Can you please sync up your branch?

@zach1221 zach1221 added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Nov 8, 2023
@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Nov 8, 2023
@epic-cicd-jenkins
Copy link
Collaborator

Jenkins-ci ORTs passed

@BrianCurtis-NOAA
Copy link
Collaborator

Delayed with WCOSS2. Had to get the 1106 BL's synced after the dev switch. Making the 11/08 copy now and will take care of the rest in the AM.

@zach1221
Copy link
Collaborator

zach1221 commented Nov 9, 2023

Ok, looks like we're ready to begin merging process. I'll follow up on the ccpp-physics pr.

@zach1221 zach1221 merged commit 9e41ad9 into ufs-community:develop Nov 9, 2023
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants