-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a condition to turn off samfdeepcnv when MYNN shallow convection active #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @XiaqiongZhou-NOAA . I think we're ready to begin testing against your PR. Can you please sync up your branch? |
36 tasks
Jenkins-ci ORTs passed |
Delayed with WCOSS2. Had to get the 1106 BL's synced after the dev switch. Making the 11/08 copy now and will take care of the rest in the AM. |
Ok, looks like we're ready to begin merging process. I'll follow up on the ccpp-physics pr. |
BrianCurtis-NOAA
approved these changes
Nov 9, 2023
sadeghitabas
approved these changes
Nov 9, 2023
SamuelTrahanNOAA
added a commit
to SamuelTrahanNOAA/ufs-weather-model
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Baseline Updates
Current baselines will be updated.
jenkins-ci
Jenkins CI: ORT build/test on docker container
Ready for Commit Queue
The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Author Checklist:
I have linked PR's from all sub-components involved in section below.
I am confirming reviews are completed in ALL sub-component PR's.
I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
RegressionTests_hera.log
I have added the list of all failed regression tests to "Anticipated changes" section.
I have filled out all sections of the template.
Description
To add a condition to turn off samfdeepcnv when the MYNN shallow convection is active.
Linked Issues and Pull Requests
Subcomponent Pull Requests
ufs-community/ccpp-physics#121
NOAA-EMC/fv3atm#714
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
control_p8_mynn_intel
Libraries
Code Managers Log
Testing Log: