-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new global_nest_v1 suite and #715 #709
Merged
jkbk2004
merged 34 commits into
NOAA-EMC:develop
from
SamuelTrahanNOAA:suite_FV3_global_nest_v1
Nov 15, 2023
Merged
new global_nest_v1 suite and #715 #709
jkbk2004
merged 34 commits into
NOAA-EMC:develop
from
SamuelTrahanNOAA:suite_FV3_global_nest_v1
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
DusanJovic-NOAA
approved these changes
Nov 3, 2023
I'm pointing to the ufs/dev branch of ccpp-physics. This PR is ready for final review and merge. |
jkbk2004
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a suite of physics schemes nominally planned for the RRFS v2 upgrade. It's being used for the Water in the West project to simulate atmospheric rivers using a global model with a static nest. Hence "global_nest_v1."
PR #715 is included by request of the UFS code managers.
Issue(s) addressed
Testing
How were these changes tested?
The suite was tested with a simulation of a February 24, 2023 atmospheric river event.
What compilers / HPCs was it tested with?
Hera intel. FV3 nesting does not work with the gnu compiler or in debug mode due to known issues.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes. There are two new tests:
Have the ufs-weather-model regression test been run? On what platform?
Hera and Jet.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
No. It adds two tests, but no tests change.
Please commit the regression test log files in your ufs-weather-model branch
Okay.
Dependencies