-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for JEDI-to-FV3 increment converter to process ensembles #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubed sphere backgrounds
Actually I have one more idea for a testing strategy, then will re-open... |
After a ton of debugging and testing, I'm finally re-opening this PR |
CoryMartin-NOAA
approved these changes
Apr 11, 2024
danholdaway
approved these changes
Apr 11, 2024
danholdaway
added a commit
that referenced
this pull request
Apr 15, 2024
* upstream/develop: remove seviri from gdas_prototype_3d yaml (#1043) Fix GW jjob tests for upcoming GW PR #2420 (#1041) Fix test output for fv3jedi_fv3inc.h (#1039) Run g-w linker script before ctest for prepoceanobs task (#1034) Update femps and fv3-jedi-lm (#1036) Add ability for JEDI-to-FV3 increment converter to process ensembles (#1022) Add AVHRR/NOAA-15/18/19 assimilation to end-to-end GDASApp validation (#997) Catch error when trying to copy missing obs files from DATA to ROTDIR in prepoceanobs (#1028)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes to JEDI-to-FV3 increment converter:
Allow processing of ensembles using the same YAML template format that the FV3-JEDI LGETKF app uses. Alternatively, a list of background/increments can be specified.
Fix incorrect calculation of FV3 increment, for variables other than delp and hydrostatic_delz, related to two issues:
a. When adding the JEDI increment to the background to get the analysis, some mixing-ratio-type variables become
negative and are set to zero by FV3-JEDI. However, when we then subtract the analysis and background after the
variable change to get delp and hydrostatic_delz, we don't get the same increment that we started with for those
mixing-ratio fields.
b. For ensemble DA, the deterministic background and JEDI increment are not the same resolution, so the background
and analysis discussed above must be interpolated to half resolution before being subtracted but after the JEDI
increment is interpolated to full resolution and added to the background. Because of these two interpolations, similar
to above, we don't get the same increment as we started with.
I now use Atlas to manually set all variables other than delp and hydrostatic_delz back to their original values, which solved both issues.
Additionally, I make the following other changes:
Testing these new features yields the following results: