Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for JEDI-to-FV3 increment converter to process ensembles #1022

Merged
merged 27 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1bda4af
Modify fv3jedi_fv3inc.h to read ensembles
DavidNew-NOAA Apr 2, 2024
672d5de
Merge branch 'develop' into feature/ensemble-jediinc2fv3
DavidNew-NOAA Apr 2, 2024
4659e3a
Fixing coding norms
DavidNew-NOAA Apr 2, 2024
dfac552
More coding norm problems (thanks Emacs)
DavidNew-NOAA Apr 2, 2024
05dffba
Last coding norm fixes (hopefully)
DavidNew-NOAA Apr 2, 2024
d867b3e
Coding norms
DavidNew-NOAA Apr 2, 2024
5f8d417
Update
DavidNew-NOAA Apr 2, 2024
03750b5
Allow fv3jedi_fv3inc.x to process ensembles
DavidNew-NOAA Apr 3, 2024
a27c7b2
Fix mistake
DavidNew-NOAA Apr 3, 2024
e3fc37f
Merge branch 'develop' into feature/lgetkf-jediinc2fv3
DavidNew-NOAA Apr 4, 2024
8edb18d
Use more current version of fv3jedi_fv3inc_lgetkf.yaml.j2 that uses c…
DavidNew-NOAA Apr 5, 2024
d58a281
Change increment converter to add and subtract only necessary increme…
DavidNew-NOAA Apr 5, 2024
cb5f504
Continued debugging of FV3 increment converter
DavidNew-NOAA Apr 5, 2024
1c82162
Merge branch 'develop' into feature/lgetkf-jediinc2fv3
DavidNew-NOAA Apr 5, 2024
10d1be7
Reverse small mistake
DavidNew-NOAA Apr 5, 2024
1ed116c
Reversing small mistake
DavidNew-NOAA Apr 5, 2024
3219c60
Cleaned up method of separating increments in FV3 increment converter
DavidNew-NOAA Apr 7, 2024
8803992
Small bug fix
DavidNew-NOAA Apr 7, 2024
a225127
Coding norms
DavidNew-NOAA Apr 7, 2024
d947e0c
Merge branch 'develop' into feature/lgetkf-jediinc2fv3
DavidNew-NOAA Apr 9, 2024
9c3e1f9
Stashing prototype changes via commit
DavidNew-NOAA Apr 10, 2024
ac05727
Final bug fix to FV3 increment converter
DavidNew-NOAA Apr 10, 2024
7e59388
Revert some changes
DavidNew-NOAA Apr 10, 2024
e202eac
Final minor updates
DavidNew-NOAA Apr 10, 2024
a8678c5
Merge branch 'develop' into feature/lgetkf-jediinc2fv3
DavidNew-NOAA Apr 10, 2024
0f555db
Coding norms
DavidNew-NOAA Apr 10, 2024
4c6bb99
More coding norms :/
DavidNew-NOAA Apr 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 0 additions & 63 deletions parm/atm/utils/fv3jedi_fv3inc.yaml.j2

This file was deleted.

62 changes: 62 additions & 0 deletions parm/atm/utils/fv3jedi_fv3inc_lgetkf.yaml.j2
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
variable change:
variable change name: Model2GeoVaLs
input variables: &bkgvars [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr,surface_geopotential_height]
output variables: &fv3incrvars [ua,va,t,sphum,ice_wat,liq_wat,o3mr,delp,hydrostatic_delz]
jedi increment variables: [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr]
fv3 increment variables: *fv3incrvars
background geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table
akbk: ./fv3jedi/akbk.nc4
layout:
- {{ layout_x }}
- {{ layout_y }}
npx: {{ npx_ges }}
npy: {{ npy_ges }}
npz: {{ npz_ges }}
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_history.yaml
jedi increment geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table
akbk: ./fv3jedi/akbk.nc4
layout:
- {{ layout_x }}
- {{ layout_y }}
npx: {{ npx_ges }}
npy: {{ npy_ges }}
npz: {{ npz_ges }}
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_history.yaml
fv3 increment geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table
akbk: ./fv3jedi/akbk.nc4
layout:
- {{ layout_x }}
- {{ layout_y }}
npx: {{ npx_ges }}
npy: {{ npy_ges }}
npz: {{ npz_ges }}
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_fv3inc.yaml
members from template:
template:
background input:
datetime: '{{ current_cycle | to_isotime }}'
filetype: cube sphere history
provider: ufs
datapath: ./bkg/mem%mem%
filename: {{ EPREFIX }}atmf006.nc
state variables: *bkgvars
jedi increment input:
filetype: cube sphere history
filename: ./anl/mem%mem%/atminc.{{ current_cycle | to_fv3time }}.nc4
provider: ufs
fv3 increment output:
filetype: auxgrid
gridtype: gaussian
filename: ./anl/mem%mem%/atminc.
pattern: '%mem%'
nmembers: {{ NMEM_ENS }}
zero padding: 3
62 changes: 62 additions & 0 deletions parm/atm/utils/fv3jedi_fv3inc_variational.yaml.j2
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
variable change:
variable change name: Model2GeoVaLs
input variables: &bkgvars [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr,phis]
output variables: &fv3incrvars [ua,va,t,sphum,ice_wat,liq_wat,o3mr,delp,hydrostatic_delz]
jedi increment variables: [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr]
fv3 increment variables: *fv3incrvars
background geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table
akbk: ./fv3jedi/akbk.nc4
layout:
- {{ layout_x }}
- {{ layout_y }}
npx: {{ npx_ges }}
npy: {{ npy_ges }}
npz: {{ npz_ges }}
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_restart.yaml
jedi increment geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table
akbk: ./fv3jedi/akbk.nc4
layout:
- {{ layout_x }}
- {{ layout_y }}
npx: {{ npx_anl }}
npy: {{ npy_anl }}
npz: {{ npz_anl }}
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_history.yaml
fv3 increment geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table
akbk: ./fv3jedi/akbk.nc4
layout:
- {{ layout_x }}
- {{ layout_y }}
npx: {{ npx_anl }}
npy: {{ npy_anl }}
npz: {{ npz_anl }}
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_fv3inc.yaml
members:
- background input:
datapath: ./bkg
filetype: fms restart
datetime: '{{ current_cycle | to_isotime }}'
filename_core: '{{ current_cycle | to_fv3time }}.fv_core.res.nc'
filename_trcr: '{{ current_cycle | to_fv3time }}.fv_tracer.res.nc'
filename_sfcd: '{{ current_cycle | to_fv3time }}.sfc_data.nc'
filename_sfcw: '{{ current_cycle | to_fv3time }}.fv_srf_wnd.res.nc'
filename_cplr: '{{ current_cycle | to_fv3time }}.coupler.res'
state variables: *bkgvars
jedi increment input:
filetype: cube sphere history
filename: ./anl/atminc.{{ current_cycle | to_fv3time }}.nc4
provider: ufs
fv3 increment output:
filetype: auxgrid
gridtype: gaussian
filename: ./anl/atminc.

91 changes: 45 additions & 46 deletions test/fv3jedi/testinput/gdasapp_fv3jedi_fv3inc.yaml
Original file line number Diff line number Diff line change
@@ -1,60 +1,59 @@
variable change:
variable change name: Model2GeoVaLs
input variables: &inputvars [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr,phis]
output variables: [ua,va,t,sphum,ice_wat,liq_wat,o3mr,delp,hydrostatic_delz]
background:
geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table_gfdl
akbk: ./fv3jedi/akbk127.nc4
layout:
- '1'
- '1'
npx: '13'
npy: '13'
npz: '127'
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_history.yaml
input:
input variables: &bkgvars [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr,phis]
output variables: &fv3incrvars [ua,va,t,sphum,ice_wat,liq_wat,o3mr,delp,hydrostatic_delz]
jedi increment variables: [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr]
fv3 increment variables: *fv3incrvars
background geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table_gfdl
akbk: ./fv3jedi/akbk127.nc4
layout:
- '1'
- '1'
npx: '13'
npy: '13'
npz: '127'
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_history.yaml
jedi increment geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table_gfdl
akbk: ./fv3jedi/akbk127.nc4
layout:
- '1'
- '1'
npx: '13'
npy: '13'
npz: '127'
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_history.yaml
fv3 increment geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table_gfdl
akbk: ./fv3jedi/akbk127.nc4
layout:
- '1'
- '1'
npx: '13'
npy: '13'
npz: '127'
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_fv3inc.yaml
members:
- background input:
filetype: cube sphere history
datapath: ../testdata/
provider: ufs
datetime: '2021-07-31T12:00:00Z'
filename: gdas.t06z.atmf006.nc
state variables: [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr,phis]
jedi increment:
input variables: [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr]
geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table_gfdl
akbk: ./fv3jedi/akbk127.nc4
layout:
- '1'
- '1'
npx: '13'
npy: '13'
npz: '127'
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_history.yaml
input:
state variables: *bkgvars
jedi increment input:
filetype: cube sphere history
datapath: ../testdata/
filename: atminc.20210731.120000.nc4
provider: ufs
fv3 increment:
geometry:
fms initialization:
namelist filename: ./fv3jedi/fmsmpp.nml
field table filename: ./fv3jedi/field_table_gfdl
akbk: ./fv3jedi/akbk127.nc4
layout:
- '1'
- '1'
npx: '13'
npy: '13'
npz: '127'
field metadata override: ./fv3jedi/fv3jedi_fieldmetadata_fv3inc.yaml
output:
fv3 increment output:
filetype: cube sphere history
filename: atminc.20210731_120000.nc4
provider: ufs
Expand Down
Loading
Loading