Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test output for fv3jedi_fv3inc.h #1039

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Fix test output for fv3jedi_fv3inc.h #1039

merged 3 commits into from
Apr 12, 2024

Conversation

DavidNew-NOAA
Copy link
Collaborator

I foolishly moved the test output print statements in fv3jedi_fv3inc.h around for aesthetic reasons AFTER I had ran test_gdasapp_fv3jedi_fv3inc to confirm that it still passed. It broke the test but I moved the print statements back to where they belong.

The test now passes.

@CoryMartin-NOAA CoryMartin-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 12, 2024
@DavidNew-NOAA DavidNew-NOAA mentioned this pull request Apr 12, 2024
Closed
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 12, 2024
@emcbot
Copy link

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Apr 12 14:05:24 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Apr 12 14:59:18 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Apr 12 15:24:56 CDT 2024
Tests: 96% tests passed, 2 tests failed out of 53
	1777 - test_gdasapp_atm_jjob_var_run (Failed)
	1778 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1039/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 12, 2024
@CoryMartin-NOAA CoryMartin-NOAA merged commit 1a84448 into develop Apr 12, 2024
15 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the bugfix/gdas_fv3inc_test branch April 12, 2024 20:27
@emcbot
Copy link

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Apr 12 19:10:10 UTC 2024 on hfe01
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Apr 12 20:00:11 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Apr 12 20:39:18 UTC 2024
Tests: 92% tests passed, 4 tests failed out of 53
	1742 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1776 - test_gdasapp_atm_jjob_var_run (Failed)
	1777 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1039/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 12, 2024
@DavidNew-NOAA
Copy link
Collaborator Author

@CoryMartin-NOAA I was not expecting this test to pass on Orion, but fail on Hera. Something about "double free or corruption (!prev)" I will have to take a look on Monday.

@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Apr 13, 2024
Merged
danholdaway added a commit that referenced this pull request Apr 15, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
08873f1 
* upstream/develop:
  remove seviri from gdas_prototype_3d yaml (#1043)
  Fix GW jjob tests for upcoming GW PR #2420 (#1041)
  Fix test output for fv3jedi_fv3inc.h (#1039)
  Run g-w linker script before ctest for prepoceanobs task (#1034)
  Update femps and fv3-jedi-lm (#1036)
  Add ability for JEDI-to-FV3 increment converter to process ensembles (#1022)
  Add AVHRR/NOAA-15/18/19 assimilation to end-to-end GDASApp validation (#997)
  Catch error when trying to copy missing obs files from DATA to ROTDIR in prepoceanobs (#1028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidNew-NOAA @emcbot @CoryMartin-NOAA