-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fellowship Directory Updates Mashup #3027
Conversation
@kristinashu , I updated the styles based on the final Redpen design. But, let me know if you would like to keep the |
1f81ff8
to
bf45bfc
Compare
Looks good! Type style looks good and it's no longer switching between uppercase and lowercase! BUT I've noticed a new bug that is here and on prod. LinkedIn link works on first page load but then doesn't work if I click on a different year. I feel like this bug keeps coming up! |
The devs have talked about this already (will insert link to discussion once I find it 🙃 ). The directory is being loaded via two files and every time we make an update to it, we have to remember to update both files. I'll go ahead and fix that now, thanks for pointing this out. |
It's working well! |
Pulse headshots have been cropped already, so the updates in Issue 3 of this pr should be uniform across all profile cards. (Reference) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
c3fdbbc
to
514efba
Compare
This pr contains the following:
Test Page (all changes can be viewed here).
More detail 👇 if you'd like to keep reading 📖
Issue 1
Closes #3000
Related PRs/issues #2803 , #2810
Investigation/Discovery 👽
...attempted to track down 🛤 what happened here, but can't seem to find 🔍 exactly where and how this bug 🐛 happened. Originally, when the component was built 🔨 , it was using the older type styles for
.h6-heading
, but this was all fixed in the type clean up 🍃 in #2810 and reestablished as.body-small
. Somehow 👀 this work reverted back to.h6-heading
which resulted in it taking on the newly established.h6-heading
styles reflected in the updated style guide. 🙃Fix
Commit: Reverted styles back to
.body-small
based on finalized Redpen design.Issue 2
LinkedIn link not working once you click to another year on the filter bar.
Comment Reference
Fix
Commit
Issue 3
Closes #3001
Related PRs/issues #2685
Fix
Commit: Updated layout between 768px and 992px.