Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fellowships Directory layout at tablet width #3001

Closed
kristinashu opened this issue Apr 10, 2019 · 4 comments · Fixed by #3027
Closed

Fellowships Directory layout at tablet width #3001

kristinashu opened this issue Apr 10, 2019 · 4 comments · Fixed by #3027
Assignees
Labels

Comments

@kristinashu
Copy link

@sabrinang has suggested a better card layout for the browser width of around 760-980px. Instead of the bio copy being really narrow, the copy should go below the pic (like on mobile).

Comp: https://redpen.io/ge7f4beac4f1723042

Medium (≥768px) @2x

Screen cap from prod:
image

cc @youriwims

@youriwims
Copy link
Contributor

I can definitely do this but, all of the images have to be cropped to a square and some of the images haven't been cropped yet. When do you think this can be done @kristinashu 😸 ?

@kristinashu
Copy link
Author

Ooooh right that! Which ones aren't square? I just had a quick look at it seemed like they were all miraculously square.

@youriwims
Copy link
Contributor

youriwims commented Apr 17, 2019

I'm looking at them at the given tablet widths, 760-980px:

2019
Caroline Sinders , Danae Valentina , Daniela Saderi, Kadija Ferryman , Renee DiResta,
Stefania Koskova

2018
An-Me Chung, Julia Kloiber , Peter Bihr , Sarah Kiden

@kristinashu
Copy link
Author

kristinashu commented Apr 17, 2019

Ok I've copped all of those!

Few notes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants