-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type cleanup & standardization work #2810
Conversation
@@ -1,3 +1,9 @@ | |||
@mixin heading($font-family, $font-weight, $letter-spacing) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This heading
mixin makes sure all headings will have all three rules set to avoid unintentional styling inheritance.
This is a HUGE PR with a ton of tedious changes so I don't expect you both to go through every single code changes. I think it would be enough if you can just focus on changes made to If you wanna learn more about the ongoing brand work, @sabrinang has things documented here https://foundation.mozilla.org/en/docs/brand/design/Typography/ (type section is pretty much up to date) |
Oh the typography section on style guide has been updated too (in case you'd like to an overview list ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ 👏 👍 💫 🙌 💕 😌 ⭐ all the emojis ha—great job on this type work guys @mmmavis @sabrinang!
Closes #2806
.scss
files. I tried to do it as much as I could but there are just too many old, unused files sitting in the codebase which made my cleanup work challenging. Once this PR is merged and those unused files are removed, we should have a follow-up PR to finish the CSS rules cleanup.--
Reminder
Since new stylings and changes have been introduced in the new heading hierarchy system (e.g.,
<h1>
<h2>
<h3>
<h4>
<h5>
now have new stylings), right after we push this PR to production we'll have to go through CMS pages and make changes to heading type to make sure headings are in the right style we want. e.g., change<h3>
elements in CMS to<h2>
We need to make sure we have time blocked for updating things in CMS pages before we push this live
Changes made to h1-h4
h1
default stylings have been updatedh2
styling set becomes the newh4
styling seth3
styling set becomes the newh2
styling seth4
styling set becomes the newh3
styling setFor details see MozillaFoundation/Design#319 (comment)