Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type cleanup & standardization work #2810

Merged
merged 28 commits into from
Mar 25, 2019
Merged

Type cleanup & standardization work #2810

merged 28 commits into from
Mar 25, 2019

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Mar 14, 2019

Closes #2806

  • We'll need to have a follow-up to clean up font related CSS rules in individual .scss files. I tried to do it as much as I could but there are just too many old, unused files sitting in the codebase which made my cleanup work challenging. Once this PR is merged and those unused files are removed, we should have a follow-up PR to finish the CSS rules cleanup.
  • Buyer's Guide styling still need to be cleaned up (outside of the scope of this ticket/PR)

--

Reminder

Since new stylings and changes have been introduced in the new heading hierarchy system (e.g., <h1> <h2> <h3> <h4> <h5> now have new stylings), right after we push this PR to production we'll have to go through CMS pages and make changes to heading type to make sure headings are in the right style we want. e.g., change <h3> elements in CMS to <h2>

We need to make sure we have time blocked for updating things in CMS pages before we push this live


Changes made to h1-h4

  1. old h1 default stylings have been updated
  2. old h2 styling set becomes the new h4 styling set
  3. old h3 styling set becomes the new h2 styling set
  4. old h4 styling set becomes the new h3 styling set

For details see MozillaFoundation/Design#319 (comment)

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 00:26 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 01:01 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 01:22 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 01:35 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 18:54 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 19:01 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 19:21 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 21:24 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 22:03 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 22:04 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 22:08 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 22:12 Inactive
@mmmavis mmmavis changed the title (WIP) type cleanup work (WIP) type cleanup & standardization work Mar 14, 2019
@mmmavis mmmavis marked this pull request as ready for review March 14, 2019 22:25
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 14, 2019 22:40 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 15, 2019 00:04 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 20, 2019 00:02 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 20, 2019 23:31 Inactive
@@ -1,3 +1,9 @@
@mixin heading($font-family, $font-weight, $letter-spacing) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This heading mixin makes sure all headings will have all three rules set to avoid unintentional styling inheritance.

@mmmavis mmmavis requested review from Pomax and youriwims March 20, 2019 23:52
@mmmavis
Copy link
Collaborator Author

mmmavis commented Mar 20, 2019

@Pomax @youriwims

This is a HUGE PR with a ton of tedious changes so I don't expect you both to go through every single code changes. I think it would be enough if you can just focus on changes made to .scss files as @sabrinang and I have already gone through few rounds of peer design-code review.

If you wanna learn more about the ongoing brand work, @sabrinang has things documented here https://foundation.mozilla.org/en/docs/brand/design/Typography/ (type section is pretty much up to date)

@mmmavis mmmavis changed the title Type cleanup & standardization work (DO NOT MERGE YET) Type cleanup & standardization work Mar 20, 2019
@mmmavis
Copy link
Collaborator Author

mmmavis commented Mar 21, 2019

Oh the typography section on style guide has been updated too (in case you'd like to an overview list )

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 21, 2019 19:56 Inactive
@youriwims youriwims self-requested a review March 22, 2019 17:16
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 22, 2019 17:18 Inactive
Copy link
Contributor

@youriwims youriwims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 👏 👍 💫 🙌 💕 😌 ⭐ all the emojis ha—great job on this type work guys @mmmavis @sabrinang!

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 22, 2019 18:51 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2810 March 22, 2019 21:06 Inactive
@mmmavis mmmavis removed the request for review from Pomax March 25, 2019 16:01
@mmmavis mmmavis changed the title (DO NOT MERGE YET) Type cleanup & standardization work Type cleanup & standardization work Mar 25, 2019
@mmmavis mmmavis merged commit 7deb038 into master Mar 25, 2019
@mmmavis mmmavis deleted the issue-2806-style-type branch April 16, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants