Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased space below Fellow name in Directory Component #2984

Closed
youriwims opened this issue Apr 9, 2019 · 0 comments
Closed

Increased space below Fellow name in Directory Component #2984

youriwims opened this issue Apr 9, 2019 · 0 comments
Assignees
@youriwims
Labels
bug engineering frontend

Comments

@youriwims
Copy link
Contributor

Describe the bug
It seems like some of the recent type updates may have altered the Fellows Directory. There's now 1rem of margin-bottom below the Fellows' names whereas previously, it looks like there was ~half that.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://foundation.mozilla.org/en/fellowships/meet-our-fellows/

Expected behavior
There should be about 50% less spacing between the Fellow's name and their location.

Previous Version (please ignore the actual card spacing, that was documented in #2707 & fixed in #2832)
Screen Shot 2019-04-09 at 11 27 34 AM

Current Behavior
Screen Shot 2019-04-09 at 10 56 21 AM

Additional context
Recent Type Updates: #2947 & #2810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youriwims youriwims

Labels
bug engineering frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@youriwims