Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated footer on PNI and maintenance page #3023

Merged
merged 10 commits into from
May 6, 2019
Merged

Updated footer on PNI and maintenance page #3023

merged 10 commits into from
May 6, 2019

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Apr 16, 2019

Closes #3006

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-3023 April 16, 2019 22:04 Inactive
mmmavis
mmmavis commented Apr 16, 2019
View reviewed changes
maintenance/static/css/main.css
@@ -7375,8 +7375,11 @@ a.text-gray-dark:focus, a.text-gray-dark:hover {
display: inline-block;
width: 20px;
height: 20px;
margin-right: 10px;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced code in this file with what's in https://foundation.mozilla.org/_css/main.compiled.css & updated a few image urls to make sure these images show up on maintenance page.

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3023 April 16, 2019 22:08 Inactive
@mmmavis
Copy link
Collaborator Author

mmmavis commented Apr 16, 2019

😃
@cadecairos - can you review the maintenance page related bits?
@Pomax - I have a question for you: https://github.com/mozilla/foundation.mozilla.org/pull/3023/files#r276014451. It would be great if you could also take a look at the rest of the code in this PR!

@mmmavis mmmavis requested review from cadecairos and Pomax April 16, 2019 22:16
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3023 April 16, 2019 22:18 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3023 April 16, 2019 22:51 Inactive
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-3023 April 22, 2019 16:45 Inactive
Pomax
Pomax previously requested changes Apr 22, 2019
View reviewed changes
cadecairos
cadecairos approved these changes Apr 22, 2019
View reviewed changes
Copy link

@cadecairos cadecairos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintenance page bits look fine to me!

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3023 April 24, 2019 01:06 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3023 April 24, 2019 01:24 Inactive
@mmmavis mmmavis requested a review from Pomax April 24, 2019 01:25
@mmmavis mmmavis dismissed Pomax’s stale review April 24, 2019 01:25

PR updated!

@mmmavis mmmavis mentioned this pull request Apr 24, 2019
Closed
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-3023 April 29, 2019 20:15 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3023 May 1, 2019 16:46 Inactive
@mmmavis mmmavis requested a review from Pomax May 1, 2019 17:02
@mmmavis
Copy link
Collaborator Author

mmmavis commented May 1, 2019

@Pomax PR updated again!

Pomax
Pomax reviewed May 6, 2019
View reviewed changes
source/js/buyers-guide/bg-main.js
@@ -194,6 +223,31 @@ let main = {
injectDonateModal(donationModal, modalOptions);
}
*/

if (document.querySelectorAll(`.join-us`)) {
var elements = Array.from(document.querySelectorAll(`.join-us`));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out that querySelectorAll returns a static NodeList, so we don't need the Array.from anymore. We might want to file a separate issue to clean up Array.from everywhere, though, and add one here even though it's new code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wanna get this PR merged so let's tackle ^ as a follow-up: #3109

@mmmavis mmmavis mentioned this pull request May 6, 2019
Closed
@mmmavis mmmavis merged commit 4ac1238 into master May 6, 2019
@Pomax Pomax deleted the issue-3006-footer-PNI-maintenance branch May 9, 2019 16:06
@snyk-bot snyk-bot mentioned this pull request Jul 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pomax Pomax Pomax approved these changes

@cadecairos cadecairos cadecairos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update footer on PNI and maintenance.html
3 participants
@mmmavis @Pomax @cadecairos