Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up "Array.from" in codebase #3109

Closed
mmmavis opened this issue May 6, 2019 · 0 comments · Fixed by #4262
Closed

Clean up "Array.from" in codebase #3109

mmmavis opened this issue May 6, 2019 · 0 comments · Fixed by #4262
Assignees
@Pomax
Labels
code cleanup engineering frontend
Milestone
Mar 9

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented May 6, 2019

From #3023 (comment)

It turns out that querySelectorAll returns a static NodeList, so we don't need the Array.from anymore.
@mmmavis mmmavis mentioned this issue May 6, 2019
Merged
kgeorgiou added a commit to kgeorgiou/foundation.mozilla.org that referenced this issue Sep 30, 2019
@kgeorgiou
clean up Array.from in codebase (closes MozillaFoundation#3109)
4865a05
@kgeorgiou kgeorgiou mentioned this issue Sep 30, 2019
Closed
1 task
@gideonthomas gideonthomas added this to the Icebox milestone Nov 8, 2019
@cadecairos cadecairos modified the milestones: Icebox, Mar 23 Feb 27, 2020
@Pomax Pomax mentioned this issue Feb 27, 2020
Merged
@Pomax Pomax modified the milestones: Mar 23, Mar 9 Feb 27, 2020
@Pomax Pomax assigned Pomax and unassigned mmmavis Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pomax Pomax

Labels
code cleanup engineering frontend
Projects
None yet
Milestone
Mar 9
4 participants
@Pomax @cadecairos @mmmavis @gideonthomas