Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Array.from where possible #4262

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Remove Array.from where possible #4262

merged 3 commits into from
Mar 6, 2020

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Feb 27, 2020

Port of #3710 onto the current codebase

Closes #3109

@Pomax Pomax requested a review from mmmavis February 27, 2020 21:57
@patjouk patjouk temporarily deployed to foundation-s-array-from-kipxkd February 27, 2020 21:57 Inactive
@Pomax Pomax mentioned this pull request Feb 27, 2020
Closed
1 task
mmmavis
mmmavis requested changes Feb 28, 2020
View reviewed changes
Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one code suggestion

@Pomax Pomax requested a review from mmmavis March 6, 2020 00:03
@mmmavis mmmavis temporarily deployed to foundation-s-array-from-mbmmpp March 6, 2020 21:19 Inactive
@mmmavis mmmavis merged commit 4c9bd81 into master Mar 6, 2020
@mmmavis mmmavis deleted the array-from branch March 6, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmmavis mmmavis mmmavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up "Array.from" in codebase
3 participants
@Pomax @mmmavis @patjouk