Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out a way to deal with site-wide shared JS code #3055

Closed
mmmavis opened this issue Apr 24, 2019 · 0 comments · Fixed by #4387
Closed

Figure out a way to deal with site-wide shared JS code #3055

mmmavis opened this issue Apr 24, 2019 · 0 comments · Fixed by #4387
Assignees
@mmmavis
Labels
code cleanup engineering
Milestone
Apr 6

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Apr 24, 2019

Originally mentioned in PR #3023

We should figure out a way to deal with side-wide shared JS code instead of duplicating the same code in both main.js and bg-main.js.
@mmmavis mmmavis mentioned this issue Apr 24, 2019
Merged
@alanmoo alanmoo changed the title Figure out a way to deal with side-wide shared JS code Figure out a way to deal with site-wide shared JS code Apr 26, 2019
@gideonthomas gideonthomas added this to the Icebox milestone Nov 8, 2019
@cadecairos cadecairos modified the milestones: Icebox, Mar 23 Feb 27, 2020
@mmmavis mmmavis mentioned this issue Mar 24, 2020
Merged
@cadecairos cadecairos modified the milestones: Mar 23, Apr 6 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
code cleanup engineering
Projects
None yet
Milestone
Apr 6
Development

Successfully merging a pull request may close this issue.

Clean up and refactor side wide shared JS code MozillaFoundation/foundation.mozilla.org
3 participants
@cadecairos @mmmavis @gideonthomas