[PORT] Fixing two fishing issues in one PR. #5532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix #83730, fix #85985 and fix #86033. See above. :cl: fix: You can no longer pickup closets and crates wrapped in a package with a fishing rod. fix: Fixed a few harddel issues with mob spawns that caused charred corpses fished from lavaland to create an invisible blockade. fix: Fixed being able to fish up mobs that have fallen in totally different z-levels with a rescue hook (i.e. from bitrunning domains to lavaland). /:cl: --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR partially ports the following PR from tgstation:
This should fix #5520. Mobs who drop into a chasm in a virtual domain will no longer be retrievable. This also incidentally splits up the "chasm fallen mob" list into different z-level categories - meaning that mobs which fall in chasms at centcom can't be retrieved from a chasm on the station; simultaneously, mobs who fall into a station-side chasm can be retrieved from any station chasm.
The PR was not fully ported - part of it relied on changes made in tgstation/tgstation#80599, which is a balance change that has not been ported yet.
Why It's Good For The Game
Fixes #5520
Changelog
🆑MichiRecRoom, Ghommie
fix: (Ghommie) Fixed a few harddel issues with mob spawns that caused charred corpses fished from lavaland to create an invisible blockade.
fix: (Ghommie) Fixed being able to fish up mobs that have fallen in totally different z-levels with a rescue hook (i.e. from bitrunning domains to lavaland).
/:cl: