Ports two of my recent /tg/ PRs #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so receiving a PDA message will give the holder a balloon alert with their ringtone. PDA messages are often ignored due to not being noticed, as many players are more often focused on the main game screen (which runechat has somewhat normalized) than the chat window. This makes things more obvious that there's a PDA message. :cl: add: PDA ringtones now show a balloon alert to the PDA holder. /:cl:
5ce307b to
9928b8c
Compare
…cloning instead of directly overlaying the master (#87281) ## About The Pull Request This reworks the `/mob/proc/throw_alert(new_master = ...)` to use appearance cloning instead of just directly adding the master atom as an overlay. There's several advantages to this: - We don't have to change anything about the original target at all - Setting the plane/layer, adding the overlay, then resetting it to before (as it does without this PR), feels like an awful hack ngl. - We can ensure the target is always facing south, and has no pixel x/y/z shift. <details> <summary><h3>Proof of testing / screenshots</h3></summary> I had the healing rod holder standing on a table when the alert was added, to ensure that the pixel_x/y/z reset worked.   </details> ## Why It's Good For The Game Ensures the aura healing alerts and such always look consistent - no pixel offsets, always facing south, with more reliable code. ## Changelog :cl: refactor: Refactored how some screen alerts, such as aura healing, show atom overlays. /:cl:
9928b8c to
af0974d
Compare
Closed
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PRs from /tg/, both by me:
Changelog
🆑
add: PDA ringtones now show a balloon alert to the PDA holder.
refactor: Refactored how some screen alerts, such as aura healing, show atom overlays.
/:cl: