Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ports two of my recent /tg/ PRs (#3896)
* PDA ringtones now show a balloon alert (#87278) This makes it so receiving a PDA message will give the holder a balloon alert with their ringtone. PDA messages are often ignored due to not being noticed, as many players are more often focused on the main game screen (which runechat has somewhat normalized) than the chat window. This makes things more obvious that there's a PDA message. :cl: add: PDA ringtones now show a balloon alert to the PDA holder. /:cl: * Master-overlayed screen alerts (i.e aura healing) now use appearance cloning instead of directly overlaying the master (#87281) ## About The Pull Request This reworks the `/mob/proc/throw_alert(new_master = ...)` to use appearance cloning instead of just directly adding the master atom as an overlay. There's several advantages to this: - We don't have to change anything about the original target at all - Setting the plane/layer, adding the overlay, then resetting it to before (as it does without this PR), feels like an awful hack ngl. - We can ensure the target is always facing south, and has no pixel x/y/z shift. <details> <summary><h3>Proof of testing / screenshots</h3></summary> I had the healing rod holder standing on a table when the alert was added, to ensure that the pixel_x/y/z reset worked.   </details> ## Why It's Good For The Game Ensures the aura healing alerts and such always look consistent - no pixel offsets, always facing south, with more reliable code. ## Changelog :cl: refactor: Refactored how some screen alerts, such as aura healing, show atom overlays. /:cl:
- Loading branch information