Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-LE SSL Certs and non-Route53 DNS providers #659

Merged
merged 4 commits into from
Feb 20, 2017

Conversation

bcongdon
Copy link
Contributor

Description

  • Exposes certificate, certificate_key, and certificate_chain in the README documentation. (Should these be renamed to *_file for clarity?)
  • Adds using_route53 option. Allows disabling Route53 record changes when doing a certify
  • Adds a sanity test for the non-Route53 method of certifying

GitHub Issues

#517 - Adds the ability to bypass the Route53 DNS record updates, allowing both custom certs and DNS
#401 - This functionality already exists, but wasn't exposed anywhere (to my knowledge) in the documentation

@Miserlou
Copy link
Owner

Oh baby! Hopefully I can get to reviewing this today.

Suggest we move using_route53 to use_route53 to be consistent, or move it to route53_enabled to be.. consistent. Requesting input on that one.

@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage decreased (-0.02%) to 81.335% when pulling c857d00 on bcongdon:manual-cert into 9c58099 on Miserlou:master.

@Miserlou
Copy link
Owner

Bumping this one, I'd like to get this merged sometime soon.

@bcongdon
Copy link
Contributor Author

I'm onboard with the config var rename. Changed it to route53_enabled to match apigateway_enabled

@coveralls
Copy link

coveralls commented Feb 20, 2017

Coverage Status

Coverage decreased (-0.4%) to 80.966% when pulling a20ad36 on bcongdon:manual-cert into 9c58099 on Miserlou:master.

@Miserlou
Copy link
Owner

Let's do it!

@Miserlou Miserlou merged commit f96b7c1 into Miserlou:master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants