Skip to content

Commit

Permalink
using_route53 -> route53_enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
bcongdon committed Feb 20, 2017
1 parent c857d00 commit a20ad36
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -488,13 +488,13 @@ to change Zappa's behavior. Use these at your own risk!
"project_name": "MyProject", // The name of the project as it appears on AWS. Defaults to a slugified `pwd`.
"remote_env": "s3://my-project-config-files/filename.json", // optional file in s3 bucket containing a flat json object which will be used to set custom environment variables.
"role_name": "MyLambdaRole", // Name of Zappa execution role. Default ZappaExecutionRole. To use a different, pre-existing policy, you must also set manage_roles to false.
"route53_enabled": true, // Have Zappa update your Route53 Hosted Zones when certifying with a custom domain
"s3_bucket": "dev-bucket", // Zappa zip bucket,
"slim_handler": false, // Useful if project >50M. Set true to just upload a small handler to Lambda and load actual project from S3 at runtime.
"settings_file": "~/Projects/MyApp/settings/dev_settings.py", // Server side settings file location,
"timeout_seconds": 30, // Maximum lifespan for the Lambda function (default 30, max 300.)
"touch": false, // GET the production URL upon initial deployment (default True)
"use_precompiled_packages": false, // If possible, use C-extension packages which have been pre-compiled for AWS Lambda
"using_route53": true, // Have Zappa update your Route53 Hosted Zones when certifying with a custom domain
"vpc_config": { // Optional VPC configuration for Lambda function
"SubnetIds": [ "subnet-12345678" ], // Note: not all availability zones support Lambda!
"SecurityGroupIds": [ "sg-12345678" ]
Expand Down Expand Up @@ -627,7 +627,7 @@ However, it's now far easier to use Route 53-based DNS authentication, which wil
1. The first step is to create a custom domain and obtain your SSL cert / key / bundle.
2. Ensure you have set the `domain` setting within your Zappa settings JSON - this will avoid problems with the Base Path mapping between the Custom Domain and the API invoke URL, which gets the Stage Name appended in the URI
3. Add the paths to your SSL cert / key / bundle to the `certificate`, `certificate_key`, and `certificate_chain` settings, respectively, in your Zappa settings JSON
4. Set `using_route53` to `false` if you plan on using your own DNS provider, and not an AWS Route53 Hosted zone.
4. Set `route53_enabled` to `false` if you plan on using your own DNS provider, and not an AWS Route53 Hosted zone.
5. Deploy or update your app using Zappa
6. Run `$ zappa certify` to upload your certificates and register the custom domain name with your API gateway.

Expand Down
2 changes: 1 addition & 1 deletion tests/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -1154,7 +1154,7 @@ def update_domain_name(self, *args, **kw):

# Test creating domain without Route53
zappa_cli.zappa_settings["stage"].update({
"using_route53": False,
"route53_enabled": False,
})
zappa_cli.zappa.calls = []
zappa_cli.zappa.domain_names["test.example.com"] = ""
Expand Down
2 changes: 1 addition & 1 deletion zappa/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -1405,7 +1405,7 @@ def certify(self, no_cleanup=False):
self.lambda_name,
self.api_stage
)
if self.stage_config.get('using_route53', True):
if self.stage_config.get('route53_enabled', True):
self.zappa.update_route53_records(domain, dns_name)
print("Created a new domain name. Please note that it can take up to 40 minutes for this domain to be "
"created and propagated through AWS, but it requires no further work on your part.")
Expand Down

0 comments on commit a20ad36

Please sign in to comment.