Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow supplying existing custom certificate in settings #401

Closed
Miserlou opened this issue Oct 17, 2016 · 3 comments
Closed

Allow supplying existing custom certificate in settings #401

Miserlou opened this issue Oct 17, 2016 · 3 comments

Comments

@Miserlou
Copy link
Owner

Let's Encrypt support is already working nicely, but we might as well add the ability to supply a local PEM that has already been created.

@Miserlou
Copy link
Owner Author

Miserlou commented Dec 5, 2016

Suggest we add the

certificate_cert, certificate_keyandcertificate_chain` fields in the settings unless you can think of better names!

@Miserlou
Copy link
Owner Author

Related? #565

@atif1996
Copy link

Its probably best to keep the actual certificate outside of source control. Really, once you've installed the custom certs into aws, they should be destroyed. However, there should be some way to map the custom domain name to the deployed api gateway.

At the moment, that mapping has to be a manual step. Would be nice if zappa looked for the existence of custom domain names matching the "domain" field in the settings. If one is found, it would map that to the newly deployed api gateway.

@Miserlou Miserlou closed this as completed Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants