[Bug]: Reject and Confirm buttons on redesigned Signatures are not fully visible when using larger font size #13516
Assignees
Labels
area-accessibility
Sev2-normal
An issue that may lead to users misunderstanding some limited risks they are taking
team-confirmations
Push issues to confirmations team
type-bug
Something isn't working
Comments
7 tasks
|
We need to adjust height of scrollable section above footer for android platform, for some reason my android setup is broken and I could not fix it. |
7 tasks
|
Removing |
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 20, 2025
## **Description** Fix issue with footer buttons not visible in IOS with large fonts. ## **Related issues** Fixes: #13516 ## **Manual testing steps** 1. In IOS device enable large fonts 2. Go to test dapp and submit signature request 3. Check if footer buttons are clearly visible ## **Screenshots/Recordings** LARGE FONTS: <img width="394" alt="Screenshot 2025-02-20 at 3 31 43 PM" src="https://github.com/user-attachments/assets/094f7998-885a-4247-80ce-8529ec8c7e1a" /> SMALL FONTS: <img width="399" alt="Screenshot 2025-02-20 at 3 36 47 PM" src="https://github.com/user-attachments/assets/bc2160e7-e6cd-4778-b463-aee55f16c984" /> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
Closed by #13626 |
jpuri
added a commit
that referenced
this issue
Feb 25, 2025
Fix issue with footer buttons not visible in IOS with large fonts. Fixes: #13516 1. In IOS device enable large fonts 2. Go to test dapp and submit signature request 3. Check if footer buttons are clearly visible LARGE FONTS: <img width="394" alt="Screenshot 2025-02-20 at 3 31 43 PM" src="https://github.com/user-attachments/assets/094f7998-885a-4247-80ce-8529ec8c7e1a" /> SMALL FONTS: <img width="399" alt="Screenshot 2025-02-20 at 3 36 47 PM" src="https://github.com/user-attachments/assets/bc2160e7-e6cd-4778-b463-aee55f16c984" /> - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
jpuri
added a commit
that referenced
this issue
Feb 25, 2025
Fix issue with footer buttons not visible in IOS with large fonts. Fixes: #13516 1. In IOS device enable large fonts 2. Go to test dapp and submit signature request 3. Check if footer buttons are clearly visible LARGE FONTS: <img width="394" alt="Screenshot 2025-02-20 at 3 31 43 PM" src="https://github.com/user-attachments/assets/094f7998-885a-4247-80ce-8529ec8c7e1a" /> SMALL FONTS: <img width="399" alt="Screenshot 2025-02-20 at 3 36 47 PM" src="https://github.com/user-attachments/assets/bc2160e7-e6cd-4778-b463-aee55f16c984" /> - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
jpuri
added a commit
that referenced
this issue
Feb 25, 2025
Fix issue with footer buttons not visible in IOS with large fonts. Fixes: #13516 1. In IOS device enable large fonts 2. Go to test dapp and submit signature request 3. Check if footer buttons are clearly visible LARGE FONTS: <img width="394" alt="Screenshot 2025-02-20 at 3 31 43 PM" src="https://github.com/user-attachments/assets/094f7998-885a-4247-80ce-8529ec8c7e1a" /> SMALL FONTS: <img width="399" alt="Screenshot 2025-02-20 at 3 36 47 PM" src="https://github.com/user-attachments/assets/bc2160e7-e6cd-4778-b463-aee55f16c984" /> - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
jpuri
added a commit
that referenced
this issue
Feb 25, 2025
## **Description** Fix issue with footer buttons not visible in IOS with large fonts. ## **Related issues** Ref: #13516 ## **Manual testing steps** 1. In IOS device enable large fonts 2. Go to test dapp and submit signature request 3. Check if footer buttons are clearly visible ## **Screenshots/Recordings** LARGE FONTS: <img width="394" alt="Screenshot 2025-02-20 at 3 31 43 PM" src="https://github.com/user-attachments/assets/094f7998-885a-4247-80ce-8529ec8c7e1a" /> SMALL FONTS: <img width="399" alt="Screenshot 2025-02-20 at 3 36 47 PM" src="https://github.com/user-attachments/assets/bc2160e7-e6cd-4778-b463-aee55f16c984" /> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Buttons in redesigned signatures on both platforms are not fully visible when larger font size is used.
Expected behavior
Buttons are fully visible and easily accessible
Screenshots/Recordings
signatures.mp4
Android:
iOS:
Steps to reproduce
Error messages or log output
Detection stage
On main branch
Version
7.41.0 (1557)
Build type
None
Device
Samsung S24 Ultra, iPhone 16
Operating system
Android
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: