cherry-pick: accessibility issue with footer buttons #13717
Merged
+20
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ad7f6ed to
43d40a5
Compare
Fix issue with footer buttons not visible in IOS with large fonts. Fixes: #13516 1. In IOS device enable large fonts 2. Go to test dapp and submit signature request 3. Check if footer buttons are clearly visible LARGE FONTS: <img width="394" alt="Screenshot 2025-02-20 at 3 31 43 PM" src="https://github.com/user-attachments/assets/094f7998-885a-4247-80ce-8529ec8c7e1a" /> SMALL FONTS: <img width="399" alt="Screenshot 2025-02-20 at 3 36 47 PM" src="https://github.com/user-attachments/assets/bc2160e7-e6cd-4778-b463-aee55f16c984" /> - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Remove scroll button from confirmation page as it is not part of the designs Fixes: MetaMask/MetaMask-planning#4277 1. Go to test dapp 2. Open any signature page with scroll 3. Ensure that scroll button does not appear https://github.com/user-attachments/assets/d6771f31-646e-4110-926e-1bd7cfbf0891 - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
43d40a5 to
993ff66
Compare
sleepytanya
approved these changes
Feb 25, 2025
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue with footer buttons not visible in IOS with large fonts.
Related issues
Ref: #13516
Manual testing steps
Screenshots/Recordings
LARGE FONTS:
SMALL FONTS:
Pre-merge author checklist
Pre-merge reviewer checklist