Skip to content

Commit

Permalink
fix: accessibility issue with footer buttons (#13626)
Browse files Browse the repository at this point in the history
Fix issue with footer buttons not visible in IOS with large fonts.

Fixes: #13516

1. In IOS device enable large fonts
2. Go to test dapp and submit signature request
3. Check if footer buttons are clearly visible

LARGE FONTS:
<img width="394" alt="Screenshot 2025-02-20 at 3 31 43 PM"
src="https://github.com/user-attachments/assets/094f7998-885a-4247-80ce-8529ec8c7e1a"
/>

SMALL FONTS:
<img width="399" alt="Screenshot 2025-02-20 at 3 36 47 PM"
src="https://github.com/user-attachments/assets/bc2160e7-e6cd-4778-b463-aee55f16c984"
/>

- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
jpuri committed Feb 25, 2025
1 parent 0df5c09 commit 583a8c0
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const styleSheet = (params: {
borderTopLeftRadius: 20,
borderTopRightRadius: 20,
paddingBottom: Device.isIphoneX() ? 20 : 0,
maxHeight: '90%',
height: '85%',
},
scrollableSection: {
padding: 4,
Expand Down

0 comments on commit 583a8c0

Please sign in to comment.