[FINE] Truncate realtime metrics instead of purging #17124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2bfd9d to
eb15681
Compare
|
Test failure should be fixed with #17098 |
eb15681 to
2b44e1f
Compare
The metrics table is separated into sub tables: metrics_00 - metrics_23, one table per hour. Deleting from the parent table delegating the deletes to the child tables. The batching for these deletes sometimes conflicts with the delegation and causes the process to run slowly. The purging process is aware of the delegation. It truncates the hourly table not associated with dates in the retain window. This removes the need for batching. Also, truncate is a more streamlined procedure. As long as this runs often, this will properly purge the metrics. * rule of thumb: (interval + retain) < 12.hours. * May work with total higher than 12 hours, but it is not advised * Default retain period is to keep 4 hours worth of data * Default purge interval is to run every 21 minutes. - https://bugzilla.redhat.com/show_bug.cgi?id=1537733 - https://bugzilla.redhat.com/show_bug.cgi?id=1553473
2b44e1f to
4097b5c
Compare
|
Checked commits gtanzillo/manageiq@d759a20~...4097b5c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
approved these changes
Mar 12, 2018
|
@simaishi yay. it is green. Anything else I can provide to help merge? |
|
Nope, we're good now, merging. |
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of:
#17017
#17051
#17050
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553473