test realtime metrics purging #17050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kicking |
gtanzillo
reviewed
Feb 26, 2018
spec/models/metric/purging_spec.rb
Outdated
| FactoryGirl.create(:metric_vm_rt, :resource_id => vm1.id, :timestamp => (hours.hours.ago + 1.minute)) | ||
| end | ||
| expect(Metric.count).to eq(17) | ||
| # keep metric for 02:13 - 22:13 |
There was a problem hiding this comment.
Should this read 22:13 - 02:13
a1270af to
b01f774
Compare
|
@gtanzillo thanks - fixed a few issues with the "keep" comments |
|
Checked commit kbrock@b01f774 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Feb 26, 2018
3 tasks
simaishi
pushed a commit
that referenced
this pull request
Mar 7, 2018
test realtime metrics purging (cherry picked from commit 89cd2bc)
|
Gaprindashvili backport details: |
gtanzillo
added a commit
to gtanzillo/manageiq
that referenced
this pull request
Mar 8, 2018
gtanzillo
added a commit
to gtanzillo/manageiq
that referenced
this pull request
Mar 8, 2018
test realtime metrics purging (cherry picked from commit 89cd2bc)
|
Backported to Fine via #17124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled out of #17017
Was going to introduce change to the metrics purging code.
This sets up tests for the edge cases