Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow individual tables to be specified for metrics #17051

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Allow individual tables to be specified for metrics #17051

merged 1 commit into from
Feb 28, 2018

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Feb 26, 2018 •
edited
Loading

pulled out of #17017

Allows us to specify which metrics table we want to use (still defaulting to an hour from now)

functionality added in #16929

This also fixes 2 bugs:

  • metrics table name metrics_1 should be metrics_01
  • metrics table name metrics_24 should be metrics_00

https://bugzilla.redhat.com/show_bug.cgi?id=1551021

@kbrock kbrock changed the title Allow individual tables to be specified for metrics [WIP] Allow individual tables to be specified for metrics Feb 26, 2018
@kbrock kbrock added the wip label Feb 26, 2018
@kbrock kbrock changed the title [WIP] Allow individual tables to be specified for metrics Allow individual tables to be specified for metrics Feb 27, 2018
@kbrock kbrock removed the wip label Feb 27, 2018
@kbrock
Copy link
Member Author

kbrock commented Feb 27, 2018

someone may want to backport this - so separating from the original PR

@kbrock kbrock mentioned this pull request Feb 27, 2018
Merged
3 tasks
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2018

Checked commit kbrock@77a8224 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@kbrock kbrock requested a review from jntullo February 27, 2018 16:55
@jrafanie
Copy link
Member

LGTM. I'm suggesting we should backport this since the original is for gaprindashvili. @kbrock Can you open a BZ for the bugs you're fixing here and add it to the description?

cc @jntullo @carbonin (thoughts?)

@jrafanie jrafanie merged commit ac0e949 into ManageIQ:master Feb 28, 2018
@jrafanie jrafanie added this to the Sprint 81 Ending Mar 12, 2018 milestone Feb 28, 2018
@jrafanie jrafanie self-assigned this Feb 28, 2018
@jrafanie
Copy link
Member

If so, please add the gaprindashvili label 🙇

@kbrock kbrock deleted the metrics_indexes branch March 1, 2018 21:48
gtanzillo added a commit to gtanzillo/manageiq that referenced this pull request Mar 8, 2018
@gtanzillo
Truncate realtime metrics instead of purging
537202b 
Manual backport of:
ManageIQ#17017
ManageIQ#17051
ManageIQ#17050

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537733
@gtanzillo gtanzillo mentioned this pull request Mar 8, 2018
Merged
gtanzillo pushed a commit to gtanzillo/manageiq that referenced this pull request Mar 8, 2018
@jrafanie @gtanzillo
Merge pull request ManageIQ#17051 from kbrock/metrics_indexes
3701509 
Allow individual tables to be specified for metrics
(cherry picked from commit ac0e949)
gtanzillo pushed a commit to gtanzillo/manageiq that referenced this pull request Mar 8, 2018
@jrafanie @gtanzillo
Merge pull request ManageIQ#17051 from kbrock/metrics_indexes
b2bfd9d 
Allow individual tables to be specified for metrics
(cherry picked from commit ac0e949)
simaishi pushed a commit that referenced this pull request Mar 9, 2018
@jrafanie @simaishi
Merge pull request #17051 from kbrock/metrics_indexes
b67f180 
Allow individual tables to be specified for metrics
(cherry picked from commit ac0e949)

https://bugzilla.redhat.com/show_bug.cgi?id=1553797
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2018

Gaprindashvili backport details:

$ git log -1
commit b67f180ebdae528b46b63f9e67f487f8c963853e
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Wed Feb 28 11:43:04 2018 -0500

    Merge pull request #17051 from kbrock/metrics_indexes
    
    Allow individual tables to be specified for metrics
    (cherry picked from commit ac0e94912b306ccc740aa2416632b0dd792ab99d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1553797

@gtanzillo gtanzillo mentioned this pull request Mar 13, 2018
Closed
@simaishi
Copy link
Contributor

Backported to Fine via #17124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jntullo jntullo Awaiting requested review from jntullo

Assignees

@jrafanie jrafanie

Labels
bug bugzilla needed enhancement fine/backported gaprindashvili/backported providers/metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kbrock @miq-bot @jrafanie @simaishi @gtanzillo @carbonin