You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to an implementation decision from datadog, hostname is interpreted as the host, but in containerized environments, this isn't necessarily accurate. Here is a more detailed description of the problem:
It seems like the solution in this context is to just not log hostname. I see that when the skip fields feature was added, there was an explicit desire to return an Err if one of the skipped fields is required according to the spec:
I appreciate the desire to adhere to the bunyan format and prevent deviation, but I'd also hate to throw the baby out with the bathwater. One option would be to relax that constraint and not return an Err. Another option would be to create explicit skip method for each of the required fields, and change those fields on the BunyanFormattingLayer to Options:
pubfnskip_hostname(mutself) -> Self
I'm happy to create a PR for whatever path you think would be best for this project.
The text was updated successfully, but these errors were encountered:
Due to an implementation decision from datadog, hostname is interpreted as the host, but in containerized environments, this isn't necessarily accurate. Here is a more detailed description of the problem:
CrowdDotDev/crowd.dev#2143
It seems like the solution in this context is to just not log
hostname
. I see that when the skip fields feature was added, there was an explicit desire to return an Err if one of the skipped fields is required according to the spec:#25 (comment)
I appreciate the desire to adhere to the bunyan format and prevent deviation, but I'd also hate to throw the baby out with the bathwater. One option would be to relax that constraint and not return an Err. Another option would be to create explicit skip method for each of the required fields, and change those fields on the
BunyanFormattingLayer
toOption
s:I'm happy to create a PR for whatever path you think would be best for this project.
The text was updated successfully, but these errors were encountered: