Cleanup hostname from bunyan fields in prod logs #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bunyan, when writing logs in json, always includes `hostname` as a field - Bunyan takes the value for that field from the os (you can check it either in `HOSTNAME` env variable, or running the `hostname` command) - On kubernetes hostname in a container resolves to the pod name - Datadog, when receiving logs, tries to match `hostname` field to a name of any host it knows about. If `hostname` field isn't present in logs, it tries to derive it from a kubernetes node, which these logs came from - When `hostname` in logs doesn't match any of the hosts Datadog knows about, Datadog won't assign any extra tags, which those hosts already have - This was creating a problem, when we assigned tags such as `account:crowd` and `cluster_name:crowd-kube-production` to nodes, which weren't propagating to logs coming from these nodes - Without this tag propagation it's impossible to tell which kubernetes cluster the logs came from - To fix that, we just make Bunyan to stop populating `hostname` field in json logs, allowing Datadog to do its magic Similar issue here: DataDog/datadog-agent#14860
themarolt
approved these changes
Jan 23, 2024
sausage-todd
added a commit
that referenced
this pull request
Jan 23, 2024
sausage-todd
added a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hostnameas a fieldHOSTNAMEenv variable, or running thehostnamecommand)hostnamefield to a name of any host it knows about. Ifhostnamefield isn't present in logs, it tries to derive it from a kubernetes node, which these logs came fromhostnamein logs doesn't match any of the hosts Datadog knows about, Datadog won't assign any extra tags, which those hosts already haveaccount:crowdandcluster_name:crowd-kube-productionto nodes, which weren't propagating to logs coming from these nodeshostnamefield in json logs, allowing Datadog to do its magicSimilar issue here: DataDog/datadog-agent#14860