Add the ability to skip fields #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! |
|
I've addressed your comments in the latest commit. Let me know if there's anything else. |
LukeMathWalker
approved these changes
Jan 8, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #16
Description of changes:
This PR adds the ability to skip fields in the output of the
BunyanFormattingLayer. I think this solves issue #16 but I'm not 100% sure.I wanted this feature myself to skip the fields
file,lineandtargetbecause they're quite spammy and not all that useful for me.I'm still relatively new to Rust so let me know if anything is obviously bad or wrong.
Note: the first commit is just running
cargo fmtto avoid polluting the actual commit with formatting changes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.