New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow setting hostname. hostname is implicitly skippable #42

Closed

bbstilson wants to merge 1 commit into LukeMathWalker:master from OzetteTech:feature/flexible-required-keys

bbstilson commented Sep 25, 2024

This PR makes hostname skippable by allowing hostname to be optional. Setting the hostname to None will skip it during message serialization.


          allow setting hostname. hostname is implicitly skippable

afdd5cd

bbstilson closed this

Author

bbstilson commented Sep 25, 2024

Sorry. I meant to open this against our fork. Though if this is appealing, we can reopen. It addresses these two tickets

bbstilson deleted the feature/flexible-required-keys branch

September 25, 2024 16:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet