CI buils with minimal and latest requirements #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@williamFalcon the test won't pass since it requires changes n the code but with this update, we are able to see in future PRs if it really fixes the PyTorch back-compatibility... |
* update requirements
|
@williamFalcon conflicts resolved... |
This was referenced Nov 13, 2019
|
also solves #519 and others who ask why some specific version is needed :) |
|
@Borda if i merge this the tests will fail. Will you update the code? |
|
I would leave code fixing for another PR as we try to keep the PR simple and just one purpose... |
|
numpy 1.16.4 is not available on my platform, so I can't install pytorch-lightning using pip. Are you planning to get this fix on Pypi soon? |
|
@lemairecarl it will be in next release and also you can install it with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at testing compatibility with minimal and lates package versions from requirements
Before submitting
What does this PR do?
Fixes #462 #519. Reaction to #491.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.