Is requirement numpy==1.16.4 really needed ?

[cedias]

Hi,

While installing ligthning via pip I saw that the numpy requirements was fixed to version 1.16.4:

ERROR: pytorch-lightning 0.5.3.2 has requirement numpy==1.16.4, but you'll have numpy 1.17.4 which is incompatible.

After a quick scroll through the source code i'm wondering: is there a reason why this requirement is so specific ?

Also, wouldn't it make more sense to use pytorch tensors to try and drop the numpy requirements ? Or at least, drop the == 1.16.4

[williamFalcon]

nah. it’s a typo. Mind submitting a PR?

great catch!

[cedias]

Here you go : #520

[Borda]

@williamFalcon we already have it here #500 waiting for you...
Btw, how it happened that this issue does not have any label?

[cedias]

wouldn't it make more sense to use pytorch tensors to try and drop the numpy requirements ?

It's probably worth noting that searching "numpy" within lightning codebase yields only 13 results...

[Borda]

Do you know a person using Python who doesn't have already installed numpy directly or as dependence? =)

[williamFalcon]

Fixed in #500