Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI builds with min & max versions #462

Closed
Borda opened this issue Nov 5, 2019 · 1 comment · Fixed by #500 or #502
Closed

CI builds with min & max versions #462

Borda opened this issue Nov 5, 2019 · 1 comment · Fixed by #500 or #502
Labels
feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@Borda
Copy link
Member

Borda commented Nov 5, 2019

We have a quite a wide range of supported version but they are not properly tested, so I would like to extend/update CI to be built with minimal and maximal versions defined in requirements.

The limitations now are that Travis build already takes about 20min and adding more test configuration would make finishing it even slower... I was recently playing with GitHub Actions Workflow (I have joined the beta program and they should be released quite soon) and it seems to be quite convenient... I would prepare such testing, but I need @williamFalcon to joint GitHub Action :)

Another alternative would it do it in CircleCI, but GitHub Action has an advantage that it simply supports all three main platforms - Linux, xOS and Win

@Borda
Copy link
Member Author

Borda commented Nov 13, 2019

I would say that having #500 is more important than #502 because the second one aims only on PyTorch compare to the first one aims at complete requirement testing... @williamFalcon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant