Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circle CI for building PyTorch 1.1/1.2/1.3 #502

Merged
merged 3 commits into from
Nov 13, 2019
Merged

Add circle CI for building PyTorch 1.1/1.2/1.3 #502

merged 3 commits into from
Nov 13, 2019

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 13, 2019

Adding one more CI to have built with all major PyTorch releases. Adding this to existing Travis will make each build too long since Travis and CircleCI will run in parallel...

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #462. Reaction to #491.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@Borda
Copy link
Member Author

Borda commented Nov 13, 2019

well, it seems that the CricleCI is so slow... :-(

@williamFalcon williamFalcon merged commit 7aaaefc into Lightning-AI:master Nov 13, 2019
@Borda
Copy link
Member Author

Borda commented Nov 13, 2019

also tests/test_gpu_models.py::test_cpu_slurm_save_load Too long with no output (exceeded 10m0s) so it should be revisited...

@Borda Borda deleted the add-CircleCI branch November 13, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI builds with min & max versions
2 participants