Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package info #395

Merged
merged 20 commits into from
Oct 28, 2019
Merged

add package info #395

merged 20 commits into from
Oct 28, 2019

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 19, 2019

reaction to #358 and re-opening #359

It would be fine to make a homepage for example from the main README file, as Github offers
see: https://guides.github.com/features/pages/
it is about %min and couple clicks... :)

@Borda Borda changed the title add package info add package info [WIP] Oct 19, 2019
@Borda
Copy link
Member Author

Borda commented Oct 19, 2019

@williamFalcon could you please add WIP app which would block merging unfinished PR... Thx
see: https://github.com/marketplace/wip

@Borda
Copy link
Member Author

Borda commented Oct 19, 2019

the package is still deeply linked on test-tube see:

from test_tube import HyperOptArgumentParser
from test_tube import Experiment

@williamFalcon
Copy link
Contributor

awesome. could u rebase master for tests?

did you try pip install -e .?

@Borda
Copy link
Member Author

Borda commented Oct 21, 2019

it still does not work :( I check the scikit-learn and scikit-image and they are not using buildins package which somehow is part of future so it is a but strange...

@Borda
Copy link
Member Author

Borda commented Oct 24, 2019

@williamFalcon any idea why the tests are failing?

'gpus_param_tests' not found in `markers` configuration option

@Borda Borda changed the title add package info [WIP] add package info Oct 24, 2019
@williamFalcon
Copy link
Contributor

@neggert @Ir1d @ jeffling @shubham anyone want to PR review this?

Copy link
Contributor

@Ir1d Ir1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I ran pip install git+https://github.com/Borda/pytorch-lightning@pkg-info.
With pytorch 1.3 installed in a fresh conda env, I got No module named 'test_tube' when importing with import pytorch_lightning as pl.
Have you met this before?

@Borda
Copy link
Member Author

Borda commented Oct 24, 2019

@Ir1d it is a consequence of one of the past decision (#36) to cut examples from the package and keep the torch_ligthning independent on workflows like mlflow/test-tube/...
but examples use test-tube and we still somehow keep pl_examples to be installed

@Borda
Copy link
Member Author

Borda commented Oct 25, 2019

@Ir1d anyway missing test_tube is not related to this PR since it was not touched in requirements... :)

@Borda
Copy link
Member Author

Borda commented Oct 28, 2019

@williamFalcon \ping

@neggert
Copy link
Contributor

neggert commented Oct 28, 2019

Looks good. Any thoughts on using the extras functionality in setuptools to handle optional testtube/mlflow/cometml dependencies?

@williamFalcon williamFalcon merged commit 37647d8 into Lightning-AI:master Oct 28, 2019
@Borda Borda deleted the pkg-info branch October 28, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants