-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mlflow is not required if not being used #441
Conversation
@neggert users shouldn't have to install mlflow or comet if they're not using it. |
Yeah, was just about to send a PR when I saw this. It was originally this way, but got messed up in #395. I have a different fix that I like better because it still throws an error if you explicitly try to import e.g. CometLogger without Comet installed. |
@@ -3,8 +3,8 @@ | |||
|
|||
try: | |||
import mlflow | |||
except ImportError: | |||
raise ImportError('Missing mlflow package.') | |||
except Exception as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not need the e
, PEP8 will complain that you define a variable which is not used
@williamFalcon @neggert I do not agree with ignoring the import error. when you try to import |
That one is fine, but with this PR you change the meaning of |
remove requirement to import mlflow