Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package info #359

Merged
merged 4 commits into from
Oct 18, 2019
Merged

add package info #359

merged 4 commits into from
Oct 18, 2019

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 11, 2019

What does this PR do?

reaction to #358

It would be fine to make a homepage for example from the main README file, as Github offers
see: https://guides.github.com/features/pages/
it is about %min and couple clicks... :)

@Borda
Copy link
Member Author

Borda commented Oct 11, 2019

btw, why is the package name pytorch_lightning not just torch_lightning the same way as PyTorch repo but imported as import torch

@Borda Borda changed the title add package info #358 add package info Oct 11, 2019
@Borda
Copy link
Member Author

Borda commented Oct 11, 2019

seems to he be failing on unrelated code...

@williamFalcon
Copy link
Contributor

fixed tests. can you rebase master?

@williamFalcon williamFalcon merged commit a7f26a6 into Lightning-AI:master Oct 18, 2019
williamFalcon added a commit that referenced this pull request Oct 18, 2019
williamFalcon added a commit that referenced this pull request Oct 18, 2019
@williamFalcon
Copy link
Contributor

@Borda I had to revert this because it broke the install.

(pl3) [user@machine5 pytorch-lightning]$ pip install numpy
Requirement already satisfied: numpy in /misc/scratch1/_Group/falcon/software/miniconda3/envs/pl3/lib/python3.6/site-packages (1.16.4)
(pl3) [user@machine5 pytorch-lightning]$ pip install -e .
Obtaining file:///home/user/Developer/pytorch-lightning
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  ERROR: Command errored out with exit status 1:
   command: /home/user/media/falcon_scratch1/software/miniconda3/envs/pl3/bin/python /home/user/media/falcon_scratch1/software/miniconda3/envs/pl3/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpw4qf53yy
       cwd: /home/user/Developer/pytorch-lightning
  Complete output (22 lines):
  Traceback (most recent call last):
    File "/home/user/media/falcon_scratch1/software/miniconda3/envs/pl3/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py", line 207, in <module>
      main()
    File "/home/user/media/falcon_scratch1/software/miniconda3/envs/pl3/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py", line 197, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/home/user/media/falcon_scratch1/software/miniconda3/envs/pl3/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py", line 54, in get_requires_for_build_wheel
      return hook(config_settings)
    File "/tmp/pip-build-env-30cwdsvd/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 146, in get_requires_for_build_wheel
      return self._get_build_requires(config_settings, requirements=['wheel'])
    File "/tmp/pip-build-env-30cwdsvd/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 127, in _get_build_requires
      self.run_setup()
    File "/tmp/pip-build-env-30cwdsvd/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 237, in run_setup
      self).run_setup(setup_script=setup_script)
    File "/tmp/pip-build-env-30cwdsvd/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 142, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 10, in <module>
      import pytorch_lightning
    File "/home/user/Developer/pytorch-lightning/pytorch_lightning/__init__.py", line 1, in <module>
      from .trainer.trainer import Trainer
    File "/home/user/Developer/pytorch-lightning/pytorch_lightning/trainer/trainer.py", line 9, in <module>
      import numpy as np
  ModuleNotFoundError: No module named 'numpy'

@williamFalcon
Copy link
Contributor

williamFalcon commented Oct 18, 2019

Please fix, resubmit PR and test (inluding pip install -e .)

Thanks!

@Borda Borda mentioned this pull request Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants