-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add package info #359
Merged
Merged
add package info #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ir1d
reviewed
Oct 11, 2019
btw, why is the package name |
seems to he be failing on unrelated code... |
fixed tests. can you rebase master? |
williamFalcon
added a commit
that referenced
this pull request
Oct 18, 2019
This reverts commit a7f26a6.
williamFalcon
added a commit
that referenced
this pull request
Oct 18, 2019
@Borda I had to revert this because it broke the install.
|
Please fix, resubmit PR and test (inluding pip install -e .) Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
reaction to #358
It would be fine to make a homepage for example from the main README file, as Github offers
see: https://guides.github.com/features/pages/
it is about %min and couple clicks... :)