Change Detune Mode to Pitch-Bend Mode in Piano Roll #4184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detuneAction also changed to PitchBend Action This is for LMMS#4174, in order to give a more descriptive name to the mode.
|
@Anonymouqs thanks, this looks great. I believe this is best targeted at
FYI, If you put "Fixes #4174" in the subject of the PR or the comment of the commit, it will auto-close the associated bug report. I'll also post it on #devtalk for review. |
|
@tresf Yes, I am comfortable with switching the target branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detuneAction also changed to PitchBend Action
Fixes #4174 in the master branch, in order to give a more descriptive name to the mode.