Change Detune To Pitch Bend in Piano Roll For Stable-1.2 #4194

Anonymouqs · 2018-02-26T15:25:35Z

Fixes #4174 in order to give a clearer name to the mode in the Piano Roll.

This Pull Request is for the 1.2 Stable Branch while there is another Pull Request for the Master Branch.

The name of detuneAction is changed into pitchBendAction as well. Fixes Issue LMMS#4174 in order to give a clearer name to the mode in the Piano Roll.

tresf · 2018-02-26T15:54:59Z

src/gui/editors/PianoRoll.cpp

@@ -4077,14 +4077,14 @@ PianoRollWindow::PianoRollWindow() :
 	QAction* drawAction = editModeGroup->addAction( embed::getIconPixmap( "edit_draw" ), tr( "Draw mode (Shift+D)" ) );
 	QAction* eraseAction = editModeGroup->addAction( embed::getIconPixmap( "edit_erase" ), tr("Erase mode (Shift+E)" ) );
 	QAction* selectAction = editModeGroup->addAction( embed::getIconPixmap( "edit_select" ), tr( "Select mode (Shift+S)" ) );
-	QAction* detuneAction = editModeGroup->addAction( embed::getIconPixmap( "automation" ), tr("Detune mode (Shift+T)" ) );
+	QAction* pitchBendAction = editModeGroup->addAction( embed::getIconPixmap( "automation" ), tr("Detune mode (Shift+T)" ) );


Did you mean to change the text for this as well?

Yeah, so the source code is clearer.

@Anonymouqs I do not understand your reply. Did you make a mistake and forget this line? Will you fix it? (Hint, the text still reads "Detune mode (Shift+T)")

Anonymouqs · 2018-02-26T19:20:51Z

Added the fix. Apologies for the confusion.

DomClark · 2018-02-26T22:03:07Z

src/gui/editors/PianoRoll.cpp

@@ -4077,14 +4077,14 @@ PianoRollWindow::PianoRollWindow() :
 	QAction* drawAction = editModeGroup->addAction( embed::getIconPixmap( "edit_draw" ), tr( "Draw mode (Shift+D)" ) );
 	QAction* eraseAction = editModeGroup->addAction( embed::getIconPixmap( "edit_erase" ), tr("Erase mode (Shift+E)" ) );
 	QAction* selectAction = editModeGroup->addAction( embed::getIconPixmap( "edit_select" ), tr( "Select mode (Shift+S)" ) );
-	QAction* detuneAction = editModeGroup->addAction( embed::getIconPixmap( "automation" ), tr("Detune mode (Shift+T)" ) );
+	QAction* pitchBendAction = editModeGroup->addAction( embed::getIconPixmap( "automation" ), tr("Pitch Bend Mode (Shift+T)" ) );


"Mode" here ought to start with a lowercase "m" for consistency with the other tooltips.

Added a new commit.

…DetuningHelper Rename DetuningHelper.h as PitchBendHelper.h: * Detune to PitchBend * detune to pitchBend PianoRoll.cpp: * detuning to pitchBend * Detuning to PitchBend

* I would reccomend testing to make sure all of the features still work. Any detune mention not pertaining to the pitch bend funtion remained detune.

PhysSong · 2018-03-08T01:57:09Z

@Anonymouqs You can find remaining detune or detuning by:

git grep -i detune -- include/ src/ plugins/ # for detune
git grep -i detuning -- include/ src/ plugins/ # for detuning

However, I think first three commits are sufficient because internal references are not important for stable releases. That may be done in master after synchronizing branches.

Anonymouqs · 2018-03-08T13:07:32Z

@PhysSong Should we discuss on #devtalk if we should revert the internal reference commits?

fix references to detuning to pitchBend

I'm at the point where I am hoping that AI will be able to carry out this repetitively tedious task of refactoring. It's simple enough for reptitiveness, but just a tad bit complex to require a human(for now)

I feel like a while true do loop

Thank you for my dilligence of making this piece of softare better. Thank you for giving the strength on not leaving this branch behind to rot for 10 years and leave LMMS with the Pitch Bench feature instead of the Detune feature. Thank you for giving the strength to go on and get into the Bassline. Thank you for the fact that this is not a corporate setting where every commit has to be 100% serious. Thank you for

PhysSong · 2018-03-09T00:35:48Z

@Anonymouqs There have been some discussions on Discord #devtalk. Changing UI part and related variable names(which is done by first three commits) seems enough for stable-1.2. Further renaming can be done later(in master).

This reverts commit 732f801.

Anonymouqs · 2018-03-09T01:57:08Z

@PhysSong I just read your message when I just finished renaming all of the code; I had to trace the dependencies of the variable names across files or else the build would crash. This branch passes through the Travis Build successfully now.

This reverts commit 1f8a502.

…oll and DetuningHelper" This reverts commit 238c824.

This reverts commit 4b57db2.

This reverts commit 76f182b.

This reverts commit 748c69a.

This reverts commit 34fd806.

This reverts commit 59b3998.

This reverts commit ae78a7b.

This reverts commit c463660.

This reverts commit f49849b.

This reverts commit ef70809.

This reverts commit 9dfea35.

This reverts commit 43162e6.

This reverts commit 699a12e.

This reverts commit c713d38.

This reverts commit f95031a.

This reverts commit 733853e.

…nymouqs/lmms into DetuneToPitchBend-Stable-1.2

tresf · 2018-03-19T15:59:25Z

Although I'm sympathetic to learning the PR process, 39 commits is growing excessive for a cosmetic change. Let's please wrap this up.

Change Detune To Pitch Bend in Piano Roll

1d34e94

The name of detuneAction is changed into pitchBendAction as well. Fixes Issue LMMS#4174 in order to give a clearer name to the mode in the Piano Roll.

Anonymouqs changed the title ~~Change Detune To Pitch Bend in Piano Roll~~ Change Detune To Pitch Bend in Piano Roll For Stable-1.2 Feb 26, 2018

tresf mentioned this pull request Feb 26, 2018

Change Detune Mode to Pitch-Bend Mode in Piano Roll #4184

Closed

tresf reviewed Feb 26, 2018

View reviewed changes

Fix Detune Mode To Pitch Bend Mode Fi

37c5fdf

DomClark reviewed Feb 26, 2018

View reviewed changes

Anonymouqs added 3 commits February 26, 2018 19:03

Decapitalize m in Pitch Bend Mode

1f8a502

Change internal references of detune to Pitch Bend in Piano Roll and …

238c824

…DetuningHelper Rename DetuningHelper.h as PitchBendHelper.h: * Detune to PitchBend * detune to pitchBend PianoRoll.cpp: * detuning to pitchBend * Detuning to PitchBend

Add final detune to pitchbend replacements

4b57db2

* I would reccomend testing to make sure all of the features still work. Any detune mention not pertaining to the pitch bend funtion remained detune.

Anonymouqs added 7 commits March 8, 2018 14:02

Replace DETUNING with PITCHBEND

76f182b

Fix InstrumentFunctions.cpp

9dfea35

fix references to detuning to pitchBend

Fix DetuningReferences (again)

748c69a

I'm at the point where I am hoping that AI will be able to carry out this repetitively tedious task of refactoring. It's simple enough for reptitiveness, but just a tad bit complex to require a human(for now)

Another fix

34fd806

I feel like a while true do loop

Audio File Processor reference fix

59b3998

Fix Patman Reference glitch

ae78a7b

Anonymouqs added 5 commits March 8, 2018 18:56

More references

953d4ad

Fix automation track test

c463660

Revert "Thank you programming gods"

5c98f79

This reverts commit 732f801.

Fix Automation Track Test

f49849b

Final Fix

ef70809

Anonymouqs added 3 commits March 19, 2018 09:12

Revert "Decapitalize m in Pitch Bend Mode"

733853e

This reverts commit 1f8a502.

Revert "Change internal references of detune to Pitch Bend in Piano R…

2c8586d

…oll and DetuningHelper" This reverts commit 238c824.

Revert "Add final detune to pitchbend replacements"

6ea5bd5

This reverts commit 4b57db2.

Anonymouqs and others added 19 commits March 19, 2018 09:26

Revert "Replace DETUNING with PITCHBEND"

beaf5f5

This reverts commit 76f182b.

Revert "Fix DetuningReferences (again)"

cac7552

This reverts commit 748c69a.

Revert "Another fix"

dfdf808

This reverts commit 34fd806.

Revert "Audio File Processor reference fix"

85958d2

This reverts commit 59b3998.

Revert "Fix Patman Reference glitch"

f01cb71

This reverts commit ae78a7b.

Revert "Fix automation track test"

43162e6

This reverts commit c463660.

Revert "Fix Automation Track Test"

d85452d

This reverts commit f49849b.

Revert "Final Fix"

d6c1d90

This reverts commit ef70809.

Revert "Fix InstrumentFunctions.cpp"

c5cd01c

This reverts commit 9dfea35.

Revert "Revert "Fix automation track test""

699a12e

This reverts commit 43162e6.

Revert "Revert "Revert "Fix automation track test"""

c119058

This reverts commit 699a12e.

Reverts Internal Changes

c713d38

Revert "Reverts Internal Changes"

f95031a

This reverts commit c713d38.

Revert "Revert "Reverts Internal Changes""

9ac2b34

This reverts commit f95031a.

Fix

c0bd032

FIx

2b04141

Revert Changes

eb4cdb3

Revert "Revert "Decapitalize m in Pitch Bend Mode""

9414e0c

This reverts commit 733853e.

Merge branch 'DetuneToPitchBend-Stable-1.2' of https://github.com/Ano…

ebc9591

…nymouqs/lmms into DetuneToPitchBend-Stable-1.2

husamalhomsi merged commit fc5fc1c into LMMS:stable-1.2 Mar 19, 2018

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022

Change Detune To Pitch Bend in Piano Roll (LMMS#4194)

1f2f78e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change Detune To Pitch Bend in Piano Roll For Stable-1.2 #4194

Change Detune To Pitch Bend in Piano Roll For Stable-1.2 #4194

Anonymouqs commented Feb 26, 2018

tresf Feb 26, 2018

Anonymouqs Feb 26, 2018

tresf Feb 26, 2018 •

edited

Loading

Anonymouqs commented Feb 26, 2018

DomClark Feb 26, 2018

Anonymouqs Feb 27, 2018

PhysSong commented Mar 8, 2018

Anonymouqs commented Mar 8, 2018

PhysSong commented Mar 9, 2018

Anonymouqs commented Mar 9, 2018 •

edited

Loading

tresf commented Mar 19, 2018

Change Detune To Pitch Bend in Piano Roll For Stable-1.2 #4194

Change Detune To Pitch Bend in Piano Roll For Stable-1.2 #4194

Conversation

Anonymouqs commented Feb 26, 2018

tresf Feb 26, 2018

Choose a reason for hiding this comment

Anonymouqs Feb 26, 2018

Choose a reason for hiding this comment

tresf Feb 26, 2018 • edited Loading

Choose a reason for hiding this comment

Anonymouqs commented Feb 26, 2018

DomClark Feb 26, 2018

Choose a reason for hiding this comment

Anonymouqs Feb 27, 2018

Choose a reason for hiding this comment

PhysSong commented Mar 8, 2018

Anonymouqs commented Mar 8, 2018

PhysSong commented Mar 9, 2018

Anonymouqs commented Mar 9, 2018 • edited Loading

tresf commented Mar 19, 2018

tresf Feb 26, 2018 •

edited

Loading

Anonymouqs commented Mar 9, 2018 •

edited

Loading