Update Enterprise manifest examples and docs #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2020 11:11
Change Enterprise manifests from kong-enterprise-k8s to kong-enterprise-edition. Update tag to current latest 2.1 patch.
lena-larionova
previously approved these changes
Oct 15, 2020
mflendrich
reviewed
Oct 22, 2020
mflendrich
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I missed the KIC repo version/registry in the course of updating various pieces of documentation to reflect the switch from kong-enterprise-k8s to kong-enterprise-edition, which broke instructions elsewhere that were updated when attempting to deploy using the example Enterprise manifests here.
That may have been intentional when 2.1 Enterprise was still in beta. It no longer is, so everything should now reflect the current 2.1 kong-enterprise-edition guidance for new installs. I think this was the last of the holdouts 🤞
Special notes for your reviewer:
@lena-larionova not actually adding this to the changelog here since there's no good release to put it in. Doc fixes in this repo are a bit odd, since changelog items are tied to code releases, and doc fixes usually go on top of the current tip of main regardless of whether they accompany a release. 1.0.1 or 1.1.0 (depending on whether or not we do a patch release) notes should include it.