changing the name of the K8s secret #2378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changing the name of the K8s secret to match what's located here: https://bit.ly/k4k8s-enterprise. Note the following on the k4k8s-enterprise YAML file: imagePullSecrets: - name: kong-enterprise-k8s-docker
|
Deploy preview for kongdocs ready! Built with commit 3d09602 |
|
The docs are actually correct here; Fel had attempted to make this exact change very recently, and we discovered yesterday that there's an error on the KIC side: #2375 (comment) |
|
I'm okay with this as long as the documents can be copied and pasted :) Either we change the values.yaml file or the docs, but whichever it is, they should match :) |
|
Yep, Travis is fixing the values.yaml. Hopefully that'll be merged soon. |
|
Closing since the fix to the yaml file is merged: Kong/kubernetes-ingress-controller#909 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing the name of the K8s secret creation command to match what's located here: https://bit.ly/k4k8s-enterprise. Note the following on the k4k8s-enterprise YAML file:
I looked at the version 1.5.x of the doc and it had it right. So I dug a bit deeper and found this to be the cause:
#2191
which used to reference: https://bit.ly/k4k8s-enterprise-beta. In this "beta", the imagePullSecrets was set to:
so it worked. However, we're using the non-beta version which has the other name.
The question becomes which one do we want to use? Whichever we use, we should make sure that the instructions can be copied and pasted. As of now, it doesn't work due to the mismatch we have in the secret names.